fix(admin): contain sidebar update status text - #94
Merged
Conversation
Signed-off-by: Tiberiu Socaci <tsocaci@makeitfuture.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update status text overflowed the fixed sidebar because its text, revision and suffix were separate flex items, including a full commit hash. Render update chips with normal text wrapping (including unbroken error paths), and show seven revision characters with the full hash on hover.
Validation: 41/41 targeted update tests passed, including Chromium layout checks for eight states at 1440, 800 and 390 px. The browser regression fails against the original CSS. Visually inspected the corrected completion status. Static checks, secret scan and DCO passed. Updated FEATURES.md, TEST-PLAN.md, CHANGELOG.md and the private QA catalog. This browser-only change is engine-independent; no live updater/restart was invoked.