Repository navigation
Support Odoo 18 and 19 from the same addon - #5
Merged
Merged
Conversation
orangebtc
enabled auto-merge (squash)
October 13, 2026 10:25
jamesw383
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Odoo 19 replaces the notification hooks used by this addon, so the previous release could not reconcile payments there. This change supports Odoo 18 and 19 from the same addon and main branch, selecting each version's native lookup and processing pipeline while sharing MakePay reconciliation logic.
Use manifest version
1.1.0, which Odoo normalizes to18.0.1.1.0or19.0.1.1.0. Preserve signed-webhook authentication and browser return behavior. Explicitly skip Odoo 19's generic amount comparison because MakePay lifecycle events can contain crypto settlement amounts rather than the original order currency. Fix checkout error translation when a returned link UID shadows Odoo's translation user lookup.Validation:
git diff --checkpassed.18.0.1.0.1and all 17 regression tests passed with PostgreSQL 16.Hosted checkout creation is mocked in regression tests; no live customer payments were initiated.