Skip to content

Support Odoo 18 and 19 from the same addon - #5

Merged
jamesw383 merged 1 commit into
mainfrom
development/odoo-18-19-compatibility
Oct 13, 2026
Merged

jamesw383 merged 1 commit into
mainfrom
development/odoo-18-19-compatibility

Conversation

@orangebtc

Copy link
Copy Markdown
Collaborator

Odoo 19 replaces the notification hooks used by this addon, so the previous release could not reconcile payments there. This change supports Odoo 18 and 19 from the same addon and main branch, selecting each version's native lookup and processing pipeline while sharing MakePay reconciliation logic.

Use manifest version 1.1.0, which Odoo normalizes to 18.0.1.1.0 or 19.0.1.1.0. Preserve signed-webhook authentication and browser return behavior. Explicitly skip Odoo 19's generic amount comparison because MakePay lifecycle events can contain crypto settlement amounts rather than the original order currency. Fix checkout error translation when a returned link UID shadows Odoo's translation user lookup.

Validation:

  • Python/XML validation and git diff --check passed.
  • Odoo 19 fresh installation and all 17 checkout/webhook regression tests passed in the official Docker image with PostgreSQL 16.
  • Odoo 18 upgrade from 18.0.1.0.1 and all 17 regression tests passed with PostgreSQL 16.
  • Verified the Odoo 18 upgrade preserves provider credentials, the existing pending transaction, its hosted link URL/UID, and subsequent reconciliation.
  • GitHub Actions now performs fresh installations and runs the same regression suite in both Odoo 18 and 19.

Hosted checkout creation is mocked in regression tests; no live customer payments were initiated.

@orangebtc
orangebtc enabled auto-merge (squash) October 13, 2026 10:25
@jamesw383
jamesw383 disabled auto-merge October 13, 2026 10:45
@jamesw383
jamesw383 merged commit b7ea5d6 into main Oct 13, 2026
3 checks passed
@jamesw383
jamesw383 deleted the development/odoo-18-19-compatibility branch October 13, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants