Skip to content

Handle multiple waitUntil at the same time without conflicts - #18

Open
maury91 wants to merge 4 commits into
makkke:masterfrom
maury91:master
Open

Handle multiple waitUntil at the same time without conflicts#18
maury91 wants to merge 4 commits into
makkke:masterfrom
maury91:master

Conversation

@maury91

@maury91 maury91 commented Sep 16, 2016

Copy link
Copy Markdown
Contributor

With these corrections now is possible to write code like this one:

await Promise.all([
  dockerCloud.waitUntilContainerIsStopped(containerA),
  dockerCloud.waitUntilContainerIsStopped(containerB)
])

@vivanov1410

Copy link
Copy Markdown
Contributor

Is it ready to be reviewed?

@maury91

maury91 commented Oct 15, 2016

Copy link
Copy Markdown
Contributor Author

Yes, it is, on top of this solution, in another branch, I have a more reliable one ( adds a periodical check to the resource to avoid cases where a message got missed ), I'm using that on staging from 2 weeks and never given me an error.

I've discovered that sometimes a message can be missed ( is really rare, happens less than the 1% of the messages )

I clean up the other branch and make a new pull request ( for the extra functionality ).
The only difference in the other branch is the name of the package ( I needed to upload it on NPM )

@vivanov1410

Copy link
Copy Markdown
Contributor

Sounds good, that would be great. Thanks for an extra effort, appreciate it 👍

@maury91 maury91 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have cleaned the other branch, now in this pull request are present all the features I've said in the other comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants