Conversation
… device public IP validation Device.validate() was returning InvalidClientIp (variant 26) when the public IP failed the is_global() check, but the correct error is InvalidPublicIp (variant 62). This caused the CLI to display "Invalid Client IP" even though the program log said "Invalid public IP: <addr>". Also update the Go SDK error formatter test to use the correct error code (62/0x3e) so the test example is coherent.
Contributor
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Device::validate()to returnInvalidPublicIp(variant 62) instead ofInvalidClientIp(variant 26) when the device public IP fails theis_global()checkThe bug caused the CLI to display "Invalid Client IP" when the program log said "Invalid public IP":
After this fix, the CLI will display "Invalid Public IP: IP conflicts with DZ prefix" which matches the
InvalidPublicIpvariant's error message.