Skip to content

Fix the is_indexed bug in the indexer. #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yilei merged 1 commit into from
Aug 5, 2026
Merged

Fix the is_indexed bug in the indexer. #40

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/pyrefdev/indexer/update_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,24 @@
from pathlib import Path

from pyrefdev import config
from pyrefdev.config import console, ALL_PACKAGES
from pyrefdev.config import console


_PACKAGE_LINE = re.compile(
r'^(\s*Package\(pypi="([^"]+)")(.*?)(, indexed=False)?(\),?)$',
re.MULTILINE,
)
_MAPPING_DIRECTORY = Path(config.__file__).parent / "mapping"


def _is_indexed(package_name: str) -> bool:
"""Whether a package has a mapping, which is what ``indexed`` records.

This reads the directory rather than pyrefdev.mapping: that module only
loads SUPPORTED_PACKAGES, which is derived from the very flag being updated,
and it is a stale snapshot of a mapping parse_docs may have just written.
"""
return (_MAPPING_DIRECTORY / f"{package_name}.py").exists()


def update_config() -> None:
Expand All @@ -23,7 +34,7 @@ def replace_package_line(match: re.Match) -> str:
indexed_false_flag = match.group(4)
closing = match.group(5)

is_indexed = package_name in ALL_PACKAGES
is_indexed = _is_indexed(package_name)
has_indexed_false = indexed_false_flag is not None

if is_indexed and has_indexed_false:
Expand Down
Loading