Day sheet: delete any entry, group flow with the period, honour group colours - #191
Merged
Merged
Conversation
… colours
The calendar day sheet was the one place every stored log is listed,
and it offered no delete at all, so a Flow log on a day that is no
longer a period day (or any system-category log) could never be
removed. Each row now has a "delete" action with a confirmation; a row
with several entries of one category deletes them all, and timed
entries can be deleted one at a time. Deletion goes through
HomeViewModel; the sheet's data is a live query so it refreshes itself.
Flow and Symptoms now sit inside the period box on a period day (flow
first) instead of under "Tracked", where they read as unrelated.
Rows used the category's raw colour token, so a category that inherits
its colour from its group rendered a neutral bubble and near-invisible
value text ("No", "Yes"). The sheet now resolves the effective token
through the groups, and a category with no colour at all shows its
value in the normal text colour.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ELZpYZSRB1DMaJiXvkcVSD
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #190 (released as v0.59.0-beta.1), covering the calendar day sheet, which that PR did not touch.
What this fixes
Nothing in the day sheet could be deleted. The sheet is the one place every stored log for a day is listed, and it offered only "edit". That left a Flow log stranded on a day that is no longer a period day: "edit" opens the day log, which does not render Flow off-period, so the entry could never be removed. Every row now has a "delete" action with a confirmation dialog. A row holding several entries of one category deletes them all (the dialog says how many); timed entries have a per-entry "delete". Deletion goes through
HomeViewModel.deleteTrackingLogs; the sheet's data is a live query, so it refreshes on its own.Values were near-invisible. Rows used the category's raw colour token and ignored the group, so a category inheriting its group's colour rendered a neutral bubble with value text in the surface tint ("No", "Yes" in the screenshots).
DayLogDatanow carries the groups and the sheet resolves the effective token through them, the same way the log screen does. A category with no colour at all shows its value in the normal text colour.Flow and Symptoms listed under "Tracked". On a period day they now sit inside the period box, flow first, instead of reading as unrelated entries.
Changes
DayLogSheet.kt: per-row delete with confirmation, period grouping of system categories, group-aware coloursHomeViewModel.kt: groups inDayLogData,deleteTrackingLogs()HomeScreen.kt: wiringchangelog/unreleased/day-sheet-delete-and-colours.json(patch)a11y_check.pypasses.🤖 Generated with Claude Code
https://claude.ai/code/session_01ELZpYZSRB1DMaJiXvkcVSD
Generated by Claude Code