Cards: opaque fill for done tasks and muted memos so the shadow ring stops showing through - #128
Merged
Merged
Conversation
…ing stops showing through A translucent surfaceVariant on an elevated Card let the platform shadow (a ring with an unfilled umbra) bleed through, which read as a thick grey border around a paler inner rectangle. Composite the 60% blend over the page background instead. Adds LESSONS.md #56. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N3hjmBPa3ZphQN8bdwBLAL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Done tasks and done/archived memos showed a thick grey border around a paler, smaller-radius inner rectangle in light mode. Active cards were fine.
Why
Both muted cards used
surfaceVariant.copy(alpha = 0.6f)as the container of aCardthat still carries 1dp elevation in light mode. HWUI draws an elevated node's shadow as a ring with an unfilled umbra, assuming the caster is opaque. Through a 60% fill the ring shows around the edge and the unfilled middle shows only the pale blend, which reads as a grey frame around an inset panel.Change
ui/theme/CardColors.ktwithmutedCardContainer(): the same 60%surfaceVariantblend, composited overcolorScheme.backgroundinto an opaque colour.TaskCardandReminderCarduse it for their done / archived state.LESSONS.mdHide chores not due for 60+ days #56 records the rule: an elevated Card never gets a translucent container.patch).🤖 Generated with Claude Code
https://claude.ai/code/session_01N3hjmBPa3ZphQN8bdwBLAL
Generated by Claude Code