Warn on the Memos list when a reminder permission is missing - #129
Merged
Conversation
The Memos tab now shows a tappable banner above the filter row whenever a system grant the chosen notification style depends on is missing. Which grants count is style-aware: notifications and exact alarms matter to every style; full-screen alarms and Do Not Disturb access only to the Alarm style, since without the full-screen grant (Android 14+) the Alarm style falls back to a heads-up whose sound lands on the notification stream and usually arrives silently. Tapping the banner opens Settings > Reminders & alerts, which now supports being opened directly on a sub-screen. The style-to-permission rule lives in a pure ReminderPermissionGrants model in the notification package, pinned by ReminderPermissionsTest. The Full-screen alarms row in Settings also now says alarms can arrive silently without it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VRyMjuZLuk1Eq1KnSukjDL
mapgie
marked this pull request as ready for review
September 10, 2026 20:51
mapgie
pushed a commit
that referenced
this pull request
Sep 11, 2026
… on the page ground The Memos list gained a permission banner on main (#129) in the same rows the tag-alarm capture plumbing touched; both are kept. The sub-screen header is a Scaffold top bar the scroll column slides under, so it now carries the page background instead of letting rows show through it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016rWgRBgBaGjrH7iWGmUeSv
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The Memos tab now shows a tappable amber banner above the filter row whenever a system permission the chosen notification style depends on is missing. Tapping it opens Settings > Reminders & alerts directly on that sub-screen.
Which permissions count is style-aware:
Without the full-screen grant (Android 14+) the Alarm style cannot launch its ring screen on a locked phone, so it falls back to a heads-up whose sound lands on the notification stream and usually arrives silently (LESSONS #52). The banner names that effect: "Full-screen alarms are off, so memos may ring silently. Tap to allow." Notification and Silent users are never nagged about the alarm-only grants.
How
notification/ReminderPermissions.kt: pureReminderPermissionGrantsmodel withmissingFor(deliveryMode)andwarningFor(deliveryMode, plural). No Android imports, pinned byReminderPermissionsTest.PermissionHelper.reminderGrants(context): one snapshot of the four grants.ui/components/core/PermissionBanner.kt: the strip, in the shared ATTENTION tone,Role.Button, polite live region, 44dp minimum height.RemindersListScreen: re-reads grants on every resume and shows the banner;ReminderUiStatenow carriesdeliveryMode.SettingsScreenaccepts apendingSubScreenso the nav graph can open it on Reminders & alerts, mirroring the existingpendingAddIntentpattern.Changelog
changelog/unreleased/memos-permission-banner.json, bump minor.🤖 Generated with Claude Code
https://claude.ai/code/session_01VRyMjuZLuk1Eq1KnSukjDL
Generated by Claude Code