Task sheets follow Settings › Colours; chores carry reminders like tasks - #142
Merged
Conversation
…axes PR #137 wired the task list card to the Settings > Colours spine+badge and icon axes, but the two sheets a tap and a long-press open (TaskOverviewSheet, EditTaskSheet) kept their own hardcoded chip and badge colours. The chore sheets already take badgeSwatch/iconSwatch; the task sheets were never given the parameters. Both task sheets now take the same two swatch parameters and resolve the header icon chip, the due badge and the category value chip through them, falling back to the urgency tone or the task accent exactly as TaskCard and the chore sheets do. TaskListScreen passes uiState.spineSwatchFor / iconSwatchFor at both call sites, so card and sheet always agree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01EA12n2jYUVdMNHPkuJborZ
mapgie
marked this pull request as ready for review
September 12, 2026 12:31
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two changes on this branch.
1. Task overview and edit sheets follow the Settings › Colours axes
PR #137 wired
TaskCardto the spine+badge and icon axes, so the list looked right. But the two sheets a task opens into kept their own hardcoded colours:TaskOverviewSheet(the tap target since Tasks & memos: colour axes fix, plus settings/gesture work #137) coloured its icon chip by urgency tone or the lavender task accent, and its due badge by tone only.EditTaskSheet(long-press) used the lavender task accent for the header chip andsecondaryContainerfor the category value chip.The chore side already passes
badgeSwatch/iconSwatchintoChoreOverviewSheetandEditChoreSheet; the task sheets were never given the parameters. Both now take the same two swatches and resolve the header icon chip, due badge and category value chip through them, with the same fallbacks asTaskCard.TaskListScreenpassesuiState.spineSwatchFor/iconSwatchForat both call sites. Changelog fragmenttask-sheet-colour-axes.json(patch);LESSONS.md#60.2. Chores carry reminders like tasks
A chore could already get a memo from the overview's Remind action, but nothing showed it afterwards: no bell on the card, no list in the overview, no Remind row in the edit sheet. Tasks had all three since #137.
ChoreUiStatecarries the chore-linked memos and exposes tested helpers:activeReminderCountFor(the card's bell),liveRemindersFor(the overview's list, soonest first) andmirroredReminderFor(the once-only memo the Edit sheet's Remind row stands for, since a chore has no reminder column of its own).ChoreCardshows a bell with the live count, exactly asTaskCarddoes.ChoreOverviewSheetlists each live reminder with a Remove control.EditChoreSheetgains the Remind row (Off / pick date and time) between Repeat every and NFC tag, per the Cozy Cream row order;ChoreDraftkeeps it across rotation. Saving reconciles the mirrored memo: same time leaves it alone, Off deletes it, a new time replaces it. Other reminders on the chore are never touched. A new chore's reminder is created once thetagsrow exists.alarmScheduler.syncReminder.Tests:
ChoreUiStateTest(count, ordering, mirrored-reminder rule, repeating memos skipped) andSheetDraftTest(Remind row read to the minute, off by default). Changelog fragmentchore-reminders.json(minor).a11y_check.pyandcheck_changelog_fragment.pypass.🤖 Generated with Claude Code
https://claude.ai/code/session_01EA12n2jYUVdMNHPkuJborZ