Skip to content

Task sheets follow Settings › Colours; chores carry reminders like tasks - #142

Merged
mapgie merged 2 commits into
mainfrom
claude/task-screen-colors-wiring-yqzf85
Sep 12, 2026
Merged

Task sheets follow Settings › Colours; chores carry reminders like tasks#142
mapgie merged 2 commits into
mainfrom
claude/task-screen-colors-wiring-yqzf85

Conversation

@mapgie

@mapgie mapgie commented Sep 12, 2026

Copy link
Copy Markdown
Owner

Two changes on this branch.

1. Task overview and edit sheets follow the Settings › Colours axes

PR #137 wired TaskCard to the spine+badge and icon axes, so the list looked right. But the two sheets a task opens into kept their own hardcoded colours:

  • TaskOverviewSheet (the tap target since Tasks & memos: colour axes fix, plus settings/gesture work #137) coloured its icon chip by urgency tone or the lavender task accent, and its due badge by tone only.
  • EditTaskSheet (long-press) used the lavender task accent for the header chip and secondaryContainer for the category value chip.

The chore side already passes badgeSwatch / iconSwatch into ChoreOverviewSheet and EditChoreSheet; the task sheets were never given the parameters. Both now take the same two swatches and resolve the header icon chip, due badge and category value chip through them, with the same fallbacks as TaskCard. TaskListScreen passes uiState.spineSwatchFor / iconSwatchFor at both call sites. Changelog fragment task-sheet-colour-axes.json (patch); LESSONS.md #60.

2. Chores carry reminders like tasks

A chore could already get a memo from the overview's Remind action, but nothing showed it afterwards: no bell on the card, no list in the overview, no Remind row in the edit sheet. Tasks had all three since #137.

  • ChoreUiState carries the chore-linked memos and exposes tested helpers: activeReminderCountFor (the card's bell), liveRemindersFor (the overview's list, soonest first) and mirroredReminderFor (the once-only memo the Edit sheet's Remind row stands for, since a chore has no reminder column of its own).
  • ChoreCard shows a bell with the live count, exactly as TaskCard does.
  • ChoreOverviewSheet lists each live reminder with a Remove control.
  • EditChoreSheet gains the Remind row (Off / pick date and time) between Repeat every and NFC tag, per the Cozy Cream row order; ChoreDraft keeps it across rotation. Saving reconciles the mirrored memo: same time leaves it alone, Off deletes it, a new time replaces it. Other reminders on the chore are never touched. A new chore's reminder is created once the tags row exists.
  • Archiving a chore silences every linked memo; unarchiving re-arms the ones still ahead, through alarmScheduler.syncReminder.

Tests: ChoreUiStateTest (count, ordering, mirrored-reminder rule, repeating memos skipped) and SheetDraftTest (Remind row read to the minute, off by default). Changelog fragment chore-reminders.json (minor). a11y_check.py and check_changelog_fragment.py pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EA12n2jYUVdMNHPkuJborZ

…axes

PR #137 wired the task list card to the Settings > Colours spine+badge and
icon axes, but the two sheets a tap and a long-press open (TaskOverviewSheet,
EditTaskSheet) kept their own hardcoded chip and badge colours. The chore
sheets already take badgeSwatch/iconSwatch; the task sheets were never given
the parameters.

Both task sheets now take the same two swatch parameters and resolve the
header icon chip, the due badge and the category value chip through them,
falling back to the urgency tone or the task accent exactly as TaskCard and
the chore sheets do. TaskListScreen passes uiState.spineSwatchFor /
iconSwatchFor at both call sites, so card and sheet always agree.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EA12n2jYUVdMNHPkuJborZ
@mapgie
mapgie marked this pull request as ready for review September 12, 2026 12:31
@mapgie
mapgie merged commit 0ef8e8d into main Sep 12, 2026
5 checks passed
@mapgie
mapgie deleted the claude/task-screen-colors-wiring-yqzf85 branch September 12, 2026 12:31
@mapgie mapgie changed the title Tasks: colour the overview and edit sheets by the Settings › Colours axes Task sheets follow Settings › Colours; chores carry reminders like tasks Sep 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants