Waner's assignments - #56
Open
Wanerrrrr wants to merge 6 commits into
Open
Conversation
Member
There was a problem hiding this comment.
assignment 1
- interesting and timely research question, appropriate dataset to explore
- the way you're handling and creating your data dirs follows best practice, so you shouldn't need any of the
possible files = [...]ornext(...)mechanics to load the data- you already did the work to put the data somewhere you can find it later - Spray showers are a good point of comparison. Nicely done on using the three different means of comparison (count, per unit area, per population) to express
- It looks like your population-based analysis was unsuccessful- let's discuss and review why not so you can add that to your work
- to your point about the distribution of spray showers perhaps not being covered by whether or not they are in a zcta, another way to measure these relationships is to understand whether there is a spray center within N minutes walking
- the way you frame the high priority analysis is useful, but we are unable to see the actual results based on the population API call not having worked
- I'm a bit confused by your auto-generated observations- you list that 2.7 high HVI ZCTAs have no mapped spray showers. What is that trying to convey? Is that a meaningful statistic?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Waner Li - Assignment 1