Repository navigation
Add GeoJSON geometry to hover, click and selection events - #7
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the location of every event as GeoJSON geometry, so the profile can be wired to a map (e.g. drawing the hovered point and the selected stretch of the route) without recomputing anything from distances.
Events
hoverandclick:lngLatis replaced bygeometry, a GeoJSONPoint.selectionandselectionend: newgeometrywith the selected stretch of the line. It has the type of the input geometry:LineStringfor aLineString,MultiLineStringfor aMultiLineString(one line per part the selection covers, never bridging the gap between two parts).[lng, lat, ele],elein meters like the input (also withunits: "imperial"). Positions and elevations are interpolated on the line, including the ends of the selection, so custom calculations can use them directly.eleof the hover point is interpolated, whileelevationstays the nearest sample, like the badge.ElevationProfilePointGeometryandElevationProfileLineGeometry.Breaking
lngLatis removed fromhoverandclick. Usee.geometry.coordinates.slice(0, 2)instead.minoranyway: the lib has not been public for longOther
minor.