Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The React Native throughput benchmark currently reports each QR through the RN UI thread and
fetch, starts its clock before the first confirmed scan, and leaves its camera resolution/FPS implicit. NativePHP PR #3 optimizes those parts on the other side of the comparison.This companion PR targets
bench/flash-throughputand brings those optimizations to the RN example:The native helper is private to the example app. Production ZXing APIs and decoder behavior are unchanged.
apps/example/THROUGHPUT.mddescribes the exact protocol, settings and remaining differences.This aligns the optimization opportunities; it does not claim measured speedup or perfect framework isolation. Camera fallback rules, native transports, reader options and the display/camera loop still differ. In particular, requested 60 FPS is not proof of delivered 60 FPS. Keep this draft until paired release runs verify the actual camera settings on the same phone.
Validation:
Pending: actual-camera/runtime testing and paired RN/NativePHP release runs on the same physical phone. No performance improvement is asserted without those measurements.