Skip to content

Document that ">=" needs no parentheses in attribute values - #273

Merged
DylanPiercey merged 4 commits into
mainfrom
dpiercey-ws-marko-trailing-bracket-8aqu7u
Aug 7, 2026
Merged

Document that ">=" needs no parentheses in attribute values#273
DylanPiercey merged 4 commits into
mainfrom
dpiercey-ws-marko-trailing-bracket-8aqu7u

Conversation

@DylanPiercey

@DylanPiercey DylanPiercey commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Updates the unenclosed > caution in the language reference: as of htmljs-parser 5.13.0 a whitespace-preceded >= in an unenclosed attribute value parses as a comparison operator, so only bare > comparisons need parentheses.

Also updates marko/@marko deps to latest (marko 6.3.33, @marko/compiler 5.41.17, etc) so the site's installed htmljs-parser is 5.13.0, matching the documented behavior.

@changeset-bot

changeset-bot Bot commented Aug 7, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 68d6030

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 44 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: c43fe1fb-8888-4ba3-b8a9-6c5eb1d07e3c

📥 Commits

Reviewing files that changed from the base of the PR and between cd9672b and 68d6030.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml and included by **
📒 Files selected for processing (2)
  • docs/reference/language.md
  • package.json
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed The description clearly explains the documentation change and the related dependency updates.
Title check ✅ Passed The title clearly identifies the main documentation change about unparenthesized ">=" expressions in attribute values.

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

PR Preview Deployed

Your changes are live at markojs.com/previews/pr-273.

commit 68d6030

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/reference/language.md`:
- Around line 229-233: Update the documentation near the `>=` example to
explicitly state that the unambiguous behavior applies when `>=` is preceded by
whitespace. Clarify that this does not imply the same behavior for forms such as
`count>=10`, while preserving the existing arrow-function explanation.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 547669a9-e09a-423c-8685-529ea910dda0

📥 Commits

Reviewing files that changed from the base of the PR and between db89905 and cd9672b.

📒 Files selected for processing (1)
  • docs/reference/language.md

Comment thread docs/reference/language.md Outdated
@DylanPiercey
DylanPiercey merged commit 3caa4e0 into main Aug 7, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant