fix(editor): preserve source scroll position while editing - #710
Open
murongg wants to merge 2 commits into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Editing a visible line in a long source document could move that line to the top of the viewport. Preserve the chosen viewport across typing, deletion, and native text replacement, revealing the caret only when it actually leaves the viewport.
The previous input-only capture missed text updates that arrive after the browser has already scrolled. Remember the last observed scroll position for that path. Observe input events even when higher-priority handlers consume them, cancel pending restores on user navigation/scrolling/blur or external document updates, and account for interface zoom when revealing an off-screen caret. Typewriter mode keeps its intentional centering.
Validation
pnpm --filter @markra/editor test: 40 files, 537 tests passed.pnpm --filter @markra/app exec vitest run src/components/MarkdownSourceEditor.test.tsx: 18 tests passed.pnpm --filter @markra/editor typecheck:test: passed.pnpm --filter @markra/editor build: passed.pnpm --filter @markra/app build: passed.Regression tests also cover IME transactions, deletion, user scrolling and selection navigation superseding a queued restore, background updates, typewriter changes, and zoomed viewport coordinates. Full native IME testing with the user's exact document remains unverified.