fix: add pointer cursor to clickable rows and chips (#20)#26
Conversation
|
Ready to review this PR? Stage has broken it down into 3 individual chapters for you:
Chapters generated by Stage for commit 25832d7 on Jun 18, 2026 5:02am UTC. |
|
Warning Review limit reached
More reviews will be available in 22 minutes and 34 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
WalkthroughAdds ChangesPointer cursor consistency fixes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
agent-p1p
left a comment
There was a problem hiding this comment.
Pip adversarial review
Verdict: no code-level findings.
Findings:
- Blocking: none in the diff.
- Suggestions: none.
- Nitpicks: none.
What I checked:
- The diff only adds
mouse-cursor: pointer;to the fiveTouchAreas named in #20: the reaction chip, the three group-member admin actions, and the archived-list row. - No sensitive paths touched. No
@tr()strings added. - CodeRabbit reports no actionable comments.
- Local
cargo +stable fmt --all -- --checkpasses.
Verification caveats:
- Local
cargo +stable check -p dm-uicould not complete in this worker because the host is missingfontconfig.pc; retrying withRUST_FONTCONFIG_DLOPEN=1fails in thefontiquedependency API surface, so I am not treating that as a PR-diff failure. - GitHub CI is currently not green: visible failures/pending checks are in workflow bootstrap/runner territory (
webfactory/ssh-agent/ deploy-key setup and one queued macOS build), before any useful project build signal. This remains a merge-gate blocker, but I do not see a code change to request for this cursor-only diff.
|
@agent-p1p please rebase on top of master to fix the CI |
e0180b1 to
466b223
Compare
|
@dannym-arx Done — rebased Post-rebase CI on this PR:
The I've left it alone rather than fold an unrelated |
|
@agent-p1p the fmt issues are NOT on master |
Several interactive TouchAreas rendered the default arrow cursor on hover, unlike comparable controls right next to them (the reactions ActionButton and the member-row avatar both set mouse-cursor: pointer). Add mouse-cursor: pointer to: - ReactionChip (reactions-row.slint) - Make admin / Remove admin / Step down member-row actions (group-member-row.slint) - Archived chat row (archived-list-item.slint) Closes #20
466b223 to
25832d7
Compare
|
@dannym-arx You're right, my apologies — the fmt failure was not pre-existing on current master. My earlier check tested against the stale base this branch was cut from ( Fixed by rebasing |
Summary
Several interactive
TouchAreas rendered the default arrow cursor on hover, while comparable controls right next to them already setmouse-cursor: pointer(the reactionsActionButtonat reactions-row.slint:97 and the member-row avatar at group-member-row.slint:23). This made reaction pills, the group admin action buttons, and archived-chat rows not feel clickable — an inconsistency, not a deliberate style.Changes
Added
mouse-cursor: pointer;to:ui/primitives/reactions-row.slint— ReactionChip touch areaui/main-pane/group-member-row.slint— Make admin / Remove admin / Step down touch areasui/archived/archived-list-item.slint— archived chat row touch areaUI-only change; no logic, no
@tr()strings added (no translation regen needed).Test Plan
cargo check -p dm-uipasses (the Slint UI tree compiles viadm-ui/build.rs).Closes #20
Summary by CodeRabbit