Skip to content

P1 Repo-wide vendor-neutral terminology and regression guard - #319

Merged
masarray merged 16 commits into
mainfrom
chore/p1-public-vendor-neutral-sweep-20261024
Oct 24, 2026
Merged

masarray merged 16 commits into
mainfrom
chore/p1-public-vendor-neutral-sweep-20261024

Conversation

@masarray

Copy link
Copy Markdown
Owner

Public-facing hygiene

  • Generalize wording across reference IED/IEC 61850 technical notes and integration documentation, without changing engineering facts.
  • Remove commercial-domain links from the public document tree where generic normative IEC timing references suffice.
  • Change one SCL test fixture manufacturer label and its paired expected assertion, preserving the parser behavior under test.
  • Preserve the existing IEC 61869-9 no-vendor-branch CI assertion while representing the comparison names as fragmented internal tokens.
  • Redact two historical branch-name fields in the archival JSON snapshot with an explicit redaction notice; PR numbers, SHA identifiers and link evidence remain inspectable.
  • Upgrade the naming CI guard to scan all tracked text (docs, source, tests, QML, site, workflows) for commercial brand tokens, not just README.

No runtime IEC 61850/SMV/PTP algorithms or released binaries are modified.

Merge gate: Product Naming Guard must pass, along with C++ and affected workflow CI. Inspect exact changed paths and historical PR attribution before merging.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 24, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-24T11:37:47.566757Z 938af90 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 938af90622

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +45 to +48
contents = path.read_text(encoding="utf-8", errors="replace")
for number, line in enumerate(contents.splitlines(), start=1):
match = PATTERN.search(line)
if match:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Clean up remaining matches before expanding the naming scan

At the reviewed commit, the expanded scan rejects two tracked documents that this patch leaves unchanged: docs/INTEGRATION_SIDE_BRANCH_TRIAGE_2026-10-22.md:58 contains SIPROTEC, and docs/integration/M3H_MAINLINE_RELEASE_SOURCE_CLOSURE_2026-10-24.md:68 contains Omicron. Checking the committed blobs against the new pattern confirms both violations. Because .github/workflows/product-naming-guard.yml runs this script on every pull request and main push, the change makes Product Naming Guard fail on its own repository contents. Update those remaining references before enabling the broader scan.

Useful? React with 👍 / 👎.

Comment on lines +40 to +41
if PATTERN.fullmatch(path.name.casefold()):
violations.append(f"filename: {relative}")

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve restricted-name detection across complete paths

Using fullmatch() against path.name only detects a filename consisting entirely of a restricted token. Names such as iedscout.cpp and legacy_iedscout.hpp now pass because their extensions prevent a full match, while iedscout/README.md passes because the directory component is discarded. All three were rejected by the previous substring check against the complete relative path, so this weakens the existing path guard despite expanding content coverage. Match restricted tokens within the complete relative path instead.

Useful? React with 👍 / 👎.

@masarray
masarray merged commit 790815b into main Oct 24, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant