Skip to content

Update minitest and rails on fasp_base and fasp_data_sharing - #194

Merged
arte7 merged 4 commits into
mainfrom
update_minitest_and_rails
Sep 14, 2026
Merged

arte7 merged 4 commits into
mainfrom
update_minitest_and_rails

Conversation

@arte7

@arte7 arte7 commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

did currently not update further, got
DEPRECATION WARNING: rails/tasks/statistics.rake is deprecated and will be removed in Rails 8.2 without replacement
what are the statistics used for? can we live without?

Implements WEB-1204

Comment thread fasp_base/fasp_base.gemspec Outdated
end

spec.add_dependency "rails", ">= 8.0.0"
spec.add_dependency "rails", ">= 8.1.2"

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this say 8.1.2 while in fasp_data_sharing it is 8.1.3? I think it would be nice to be consistent here.

@oneiros

oneiros commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

did currently not update further, got DEPRECATION WARNING: rails/tasks/statistics.rake is deprecated and will be removed in Rails 8.2 without replacement what are the statistics used for? can we live without?

I do not think there is anything further to update?

As for the deprecation warning, that is a weird one. That file is not in in this repo, afaict it comes from rails itself.

@arte7

arte7 commented Sep 14, 2026

Copy link
Copy Markdown
Contributor Author

that file is being loaded in the Rakefile

require "bundler/setup"

APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
load "rails/tasks/engine.rake"

load "rails/tasks/statistics.rake"

require "bundler/gem_tasks"

@arte7
arte7 requested a review from oneiros September 14, 2026 13:39
@oneiros

oneiros commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

that file is being loaded in the Rakefile

require "bundler/setup"

APP_RAKEFILE = File.expand_path("test/dummy/Rakefile", __dir__)
load "rails/tasks/engine.rake"

load "rails/tasks/statistics.rake"

require "bundler/gem_tasks"

💡

Ah, that makes sense then. I see no harm in removing that.

@arte7
arte7 merged commit 1df671c into main Sep 14, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants