Update minitest and rails on fasp_base and fasp_data_sharing - #194
Merged
Merged
Conversation
oneiros
reviewed
Sep 14, 2026
| end | ||
|
|
||
| spec.add_dependency "rails", ">= 8.0.0" | ||
| spec.add_dependency "rails", ">= 8.1.2" |
Collaborator
There was a problem hiding this comment.
Why does this say 8.1.2 while in fasp_data_sharing it is 8.1.3? I think it would be nice to be consistent here.
Collaborator
I do not think there is anything further to update? As for the deprecation warning, that is a weird one. That file is not in in this repo, afaict it comes from rails itself. |
Contributor
Author
|
that file is being loaded in the |
Collaborator
💡 Ah, that makes sense then. I see no harm in removing that. |
oneiros
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did currently not update further, got
DEPRECATION WARNING: rails/tasks/statistics.rake is deprecated and will be removed in Rails 8.2 without replacementwhat are the statistics used for? can we live without?
Implements WEB-1204