fix: declare swig as a real dependency, document browser-usage constraint - #3
Merged
Merged
Conversation
…aint swig was only in devDependencies despite src/js/utils.ts importing it at module load — any consumer installing @mat3ra/jode alone got MODULE_NOT_FOUND. It only worked for downstream packages that happened to also declare swig themselves (job-designer, workflow-designer). No logic change: renderJinjaTemplate only ever compiles in-memory strings, never loads templates from disk, so it's safe in a browser bundle. Added a comment documenting that constraint (swig's file-loading features use fs, which is an empty stub under browser polyfills).
timurbazhirov
force-pushed
the
fix/swig-manifest-dependency
branch
from
July 11, 2026 07:55
69474b5 to
7c750ef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MODULE_NOT_FOUND. It only worked for downstream packages (job-designer, workflow-designer) that happened to also declare swig themselves.renderJinjaTemplateonly ever compiles in-memory strings, never loads templates from disk, so it's safe in a browser bundle — swig's file-loading features (fs-based) are not.Test plan
npm test— 21 passing@mat3ra/jode) builds and renders with 0 runtime errors after this fix