Skip to content

added mutable-immutable solution code - #3769

Closed
johansec2 wants to merge 4 commits into
mate-academy:masterfrom
johansec2:master
Closed

added mutable-immutable solution code#3769
johansec2 wants to merge 4 commits into
mate-academy:masterfrom
johansec2:master

Conversation

@johansec2

Copy link
Copy Markdown

No description provided.

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

I am approving your solution. You met the core task requirements: you defined exactly eight variables with different data types, and your sorted_variables dictionary correctly groups mutable types (list, set, dict) and immutable types (int, float, bool, string, tuple). Functionality appears complete and accurate.

Minor notes to address from linting (not blocking):

  • Line 19: E501 (80 > 79 chars) and W291 (trailing whitespace). Consider breaking the long line across parentheses and remove the trailing space.
  • Line 20: E501 (95 > 79 chars). Wrap this line similarly or introduce an intermediate variable.
  • Line 22: W391 (blank line at end of file). Ensure the file ends with a single newline and no extra blank line.

Great job on correctness; fix the style issues to get CI green. Keep up the good work!


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Important

Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.

Tip

If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.

Caution

Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.

Footnotes

  1. Rate AI review example

  2. Re-request AI review example

  3. Add AI review comments example

@johansec2 johansec2 left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modifed solution

@johansec2 johansec2 closed this Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants