feat(i18n): localize the editor; bump to 1.3 (build 10) - #19
Closed
markm39 wants to merge 1 commit into
Closed
Conversation
Extends the string catalogs with editor and tools sections in all 13 languages: header status line (Page X of Y / saving / saved / failed), the unreadable-note recovery screen, start-blank and save-failed dialogs, export errors, insert-image menu, background sheet, page sidebar and toolbar accessibility labels, text box placeholders, and tool names. New notes are created with a localized default title, and BACKGROUND_LABELS is removed in favor of the catalog. Bumps the app to 1.3 (build 10) across app.json, build.gradle, project.pbxproj, and Info.plist for the release carrying iCloud backup, the onboarding backup choice, and localization. Verified on iPad simulator in German end to end: create-note sheet (Blanko/Liniert/Kariert/Gepunktet/Millimeterpapier), editor header 'Seite 1 von 1 · bereit', back button 'Bibliothek', default title 'Ohne Titel'. Typecheck enforces catalog completeness; 43/43 tests; Metro export bundles. Claude-Session: https://claude.ai/code/session_01YM3PBapEXHwuXY97Bibsqk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR B of 2 — stacked on #18 (merge that first; GitHub retargets this to main automatically)
Completes app localization with the editor surface in all 13 languages: header status ("Seite 1 von 1 · bereit"), the unreadable-note recovery screen, start-blank/save-failed/export dialogs, insert-image menu, background sheet, page sidebar + toolbar accessibility labels, text placeholders, and tool names. New notes now get a localized default title ("Ohne Titel", "無題", …) instead of stored English.
Also bumps the app to 1.3 (build 10) in all four version locations — this is the release train for iCloud backup + onboarding choice + localization, matching the fastlane metadata and 1.3 release notes already on main.
Verified end-to-end on the iPad simulator in German (screenshots in session): create-note flow and editor fully localized. Typecheck enforces catalog completeness across locales; 43/43 tests; Metro export bundles.
https://claude.ai/code/session_01YM3PBapEXHwuXY97Bibsqk