Conversation
…istry.mount TypeDoc conversion of dockview-vue failed on master with TS2345: VuePart<T> passed `this.vueComponent` (VueComponent<T>) to VueRendererRegistry.mount, whose parameter is the non-generic VueComponent (VueComponent<any>). A newer Vue 3.5.x pulled in by the v7.0.3 lockfile bump tightened DefineComponent so that DefineComponent<T> is no longer assignable to DefineComponent<any>. mount() stores the component type-erased (markRaw into a non-generic field), so cast at the call site to match every other call site in the file. The non-registry branch keeps full T inference via the generic mountVueComponent.
…3d6y8j fix(dockview-vue): fix TypeDoc TS2345 failure in registry.mount call
11 tasks
Owner
Author
|
Superseded by #1509, which is the same Generated by Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Merges
masterintov8-branchto carry over the TypeDocTS2345fix from #1507, so thedeploy-docs/ typedoc step passes on v8-branch too. v8-branch has the identical failing construct (VuePartpassingVueComponent<T>into the non-genericregistry.mount) and the same resolved Vue 3.5.34, so it fails the same way without this.masteris 3 commits ahead ofv8-branch(merge basefa5c83c):b0c2ef0chore(release): publish v7.0.3d1682e8fix(dockview-vue): cast component to non-generic VueComponent for registry.mount94d5fb5merge fix(dockview-vue): fix TypeDoc TS2345 failure in registry.mount call #1507A local dry-run merge surfaced 2 conflicts, both from the v7.0.3 release commit (
b0c2ef0) — not from the TypeDoc fix:packages/dockview-modules/package.json— deleted on v8-branch, modified by the release on master (modify/delete)packages/dockview/package.json— version content conflictThese are release-versioning / package-structure decisions (v8-branch intentionally removed
dockview-modules), so they're left for a maintainer to resolve rather than guessed at here. Theutils.tsfix itself merges cleanly.Type of change
Affected packages
dockview-vueHow to test
After resolving the conflicts, from v8-branch:
yarn install→npx nx run-many -t build,build:bundle --projects=dockview-core,dockview,dockview-vue,dockview-react,dockview-angular→npx typedocshould exit 0 withFound 0 errors.🤖 Generated with Claude Code
Generated by Claude Code