Skip to content

Bump Ruma/uniffi - #6947

Open
poljar wants to merge 1 commit into
mainfrom
poljar/bump-uniffi
Open

Bump Ruma/uniffi#6947
poljar wants to merge 1 commit into
mainfrom
poljar/bump-uniffi

Conversation

@poljar

@poljar poljar commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Bumping Ruma and Uniffi.

Since Ruma depends on 0.32.0 of Uniffi, we need to bump to that version as well.

At the same time testing matrix-org/complement-crypto#275.

@poljar
poljar requested review from a team as code owners August 31, 2026 12:03
@poljar
poljar requested review from Hywan and richvdh and removed request for a team August 31, 2026 12:03

@Hywan Hywan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to me.

@codecov

codecov Bot commented Aug 31, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.26%. Comparing base (6602de5) to head (03dfb18).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6947   +/-   ##
=======================================
  Coverage   90.25%   90.26%           
=======================================
  Files         408      408           
  Lines      117838   117838           
  Branches   117838   117838           
=======================================
+ Hits       106359   106369   +10     
+ Misses       7526     7515   -11     
- Partials     3953     3954    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

@codspeed-hq

codspeed-hq Bot commented Aug 31, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 50.32%

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

❌ 1 regressed benchmark
✅ 49 untouched benchmarks

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
Restore session [memory store] 234.9 ms 472.9 ms -50.32%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing poljar/bump-uniffi (03dfb18) with main (6602de5)

Open in CodSpeed

@poljar
poljar force-pushed the poljar/bump-uniffi branch from 008f9d3 to 50670a4 Compare August 31, 2026 16:37

@andybalaam andybalaam left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changelog update needed?

@andybalaam
andybalaam removed the request for review from richvdh September 2, 2026 12:13
@poljar

poljar commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Any changelog update needed?

Probably, though not sure what to mention. I guess at least a "this was bumped" would be helpful. The patch still needs some work as well.

@zecakeh

zecakeh commented Sep 4, 2026

Copy link
Copy Markdown
Collaborator

Note that Ruma 0.17.0 was just released.

@poljar

poljar commented Sep 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks, will update the PR.

@poljar
poljar force-pushed the poljar/bump-uniffi branch 2 times, most recently from 4d69558 to 513a02f Compare September 7, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants