ci: add manual race cache seed comparison entrypoint - #29125
Conversation
Qodo reviews are paused for this user.Troubleshooting steps vary by plan Learn more → On a Teams plan? Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center? |
XuPeng-SH
left a comment
XuPeng-SH
left a comment
There was a problem hiding this comment.
Reviewed exact head c552d88d81f5c86dce71942cd31071191ee201de; self-authored PR, so COMMENT only. Force review completed without requiring green CI.
PASS — no actionable P0–P2 findings. Traced the manual caller through the pinned CI#456 reusable workflow, sample execution, input validation, cache importer and comparison. The workflow is manual-only, guarded to the official repository/main, uses contents:read, validates immutable SHAs/image references and repetitions, and leaves production seeding default-off. CI#456 is merged with a tree identical to the pinned implementation.
Evidence gaps remain for live caller dispatch, full cold/warm A/B, cancellation and artifact-content inspection; the ci environment has no approval gate, and local actionlint was unavailable. Retain default-off rollout; this review does not establish a speedup.
The first manual race canary run failed before creating jobs because GitHub Actions could not resolve the reusable workflow at the pre-merge CI PR commit: https://github.com/matrixorigin/matrixone/actions/runs/35486933005 Update both immutable pins to CI #456's merged commit c76c48c66de9e4684696a02510835a21d4a0aad9. The old and new commits have the identical Git tree f6f9634a3bde49271a883a1743ec88104700ffcb, so workflow and importer content are unchanged. Diff whitespace checks pass; runtime resolution must be verified by dispatch after merge. Related #29125; related #27076.
This branch was successfully deployed
2 participants
What
Add a manual-only MatrixOne workflow entrypoint for the paired race UT cache-seeding experiment implemented by matrixorigin/CI#456.
The caller pins the reviewed CI implementation commit and forwards the existing UT credentials with
secrets: inherit. It is guarded tomatrixorigin/matrixoneonmain; ordinary PR CI and production seed defaults are unchanged.Why a MatrixOne PR is needed
The reusable workflow lives in the CI repository, but the existing UT credentials are available to MatrixOne workflows. Keeping the thin caller here avoids copying credentials and lets a maintainer manually select one immutable MatrixOne SHA, image digest, and one or three paired repetitions.
Validation
state=seededand complete cleanup, then passed a forcedgo test -race -count=1smoke.Depends on matrixorigin/CI#456. Merge CI#456 first, then this PR, then dispatch the cold/warm A/B run.
Related #27076