Don't DM the PR author for every inline comment in a submitted review - #1050
Conversation
GitHub already emits a single pull_request_review event for the submission; top-level review comments are covered by that notification, so only thread replies should send a separate author DM. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Included review availability: 2 reviews are currently available. Your included PR review attempts over the past 7 days set your current allowance at 4 reviews per hour. 📝 WalkthroughWalkthroughThe webhook now sends review comment author notifications only for threaded replies. A new test helper creates reply events, and tests cover threaded replies, top-level comments, unmapped authors, and muted senders. ChangesReview comment routing
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This localized change prevents duplicate author DMs when a review contains multiple inline comments while preserving notifications for replies and mentions. No actionable merge-blocking risk remains after normal checks and review. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
avasconcelos114
left a comment
There was a problem hiding this comment.
Thanks for the PR and for flagging this!
Summary
pull_request_review_commentevents. GitHub emits one of those webhooks per inline comment when a review is submitted.in_reply_to_idunset); those are already covered byhandlePullRequestReviewNotification. Still DM for thread replies, and still notify on @mentions.QA Notes
Release Note
Made with Cursor
Change Impact: 🟡 Medium
Reasoning: The change modifies user-facing notification behavior in the webhook handler. Tests cover top-level comments and thread replies, and the change has a narrow blast radius.
Regression Risk: Medium. Incorrect reply detection could suppress valid author notifications or create duplicate notifications. Existing tests cover the main paths.
** QA Recommendation:** Perform targeted manual QA for submitted reviews with top-level comments, thread replies, edited comments, deleted comments, and
@mentions. Skipping manual QA presents a low-to-medium risk because automated coverage exists.Generated by CodeRabbitAI