Skip to content

fix(ios): resolve reactHost lazily so paste works under Expo bridgeless #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janicduplessis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(ios): resolve reactHost lazily so paste works under Expo bridgeless #56

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ios/PasteInputModule.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ @interface PasteInputModule ()
@property (nonatomic, strong) NSMutableDictionary<NSString *, NSNumber *> *registrationGenerations;
@end

static id _reactHost = nil;
static RCTRootViewFactory *_rootViewFactory = nil;

@implementation PasteInputModule

Expand All @@ -55,7 +55,12 @@ + (BOOL)requiresMainQueueSetup
+ (void)setup:(RCTRootViewFactory *)rootViewFactory
{
#ifdef RCT_NEW_ARCH_ENABLED
_reactHost = rootViewFactory.reactHost;
// The RCTHost is created lazily by the root view factory when the first
// surface mounts, which can happen after +setup: runs (e.g. under Expo,
// where the app is set up before the first surface renders). So keep the
// factory and read reactHost from it at lookup time instead of capturing a
// (possibly nil) value here.
_rootViewFactory = rootViewFactory;
#endif
}

Expand Down Expand Up @@ -173,9 +178,11 @@ - (void)removeListeners:(double)count
- (nullable id)getSurfacePresenter
{
#ifdef RCT_NEW_ARCH_ENABLED
// Read the host fresh from the factory (see +setup: for why it's not cached).
id reactHost = _rootViewFactory.reactHost;
// Try bridgeless mode first (if reactHost is set)
if (_reactHost) {
return [_reactHost performSelector:@selector(surfacePresenter)];
if (reactHost) {
return [reactHost performSelector:@selector(surfacePresenter)];
}
// Fallback to bridge mode (Fabric with bridge enabled)
else if (self.bridge) {
Expand Down