push,messagix: add native Messenger Android push registration - #351
Merged
Merged
Conversation
iFixRobots
changed the title
iFixRobots
changed the title
Choosing the right flow is the client's responsibility
tulir
changed the title
tulir
reviewed
Sep 15, 2026
tulir
reviewed
Sep 15, 2026
| log.Warn(). | ||
| Str("message_id", msgID). | ||
| Msg("Push message still wasn't bridged after backfill") | ||
| return fmt.Errorf("push message %s wasn't bridged after backfill", msgID) |
Member
There was a problem hiding this comment.
Hmm, returning an error for this might just cause loops where it tries handling the same push over and over even if it's never going to work
tulir
approved these changes
Sep 15, 2026
tulir
left a comment
tulir
left a comment
Member
There was a problem hiding this comment.
Looks good, other than that one error return which might be best to revert to a log
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Cookie-only Messenger sessions cannot register native encrypted push notifications.
Fix
Prefer the Messenger Android login flow. Preserve native credentials, device identity and push keys, and register FCM with Graph and the encrypted connection. Keep the existing iOS cookie login behavior.
Handle native relay payloads through background sync, return failed or incomplete catch-up for retry, retain messages when chat sync fails, and reject invalid push data before indexing it.
Notes
Existing cookie-only connections must log in again with Messenger Android. Beeper must promote
bridge:local-facebook:login:messenger-lite-androidfor automatic selection; the existing iOS login flag otherwise takes precedence. Cached relay registrations must renew through the SDK's trusted re-registration event or normal expiry before selecting FCM. This uses existing client APIs.Beeper relay support requires push-receiver#4, included in hungryserv#588.
Build and vet pass. A normal Pixel login registered its own push keys. A real encrypted provider push, forwarded with the existing relay serializer, produced a Beeper notification while the app was in the background. Replaying it after process death restarted the bridge without duplicate messages or notifications. These checks used a controlled relay forward; automatic server forwarding and iOS delivery still need release verification.