Repository navigation
docs(adr): accept ADR-0040 - #248
Merged
Merged
Conversation
ADR-0040: status accepted, ratifiedBy @mbeacom. Reviewed against every record it relates to and the three recorded after it (0041-0043); none conflicts. 0005 is superseded, and the record already routes that citation to 0027. Action items 1-4 were verified against the tree: scripts/emit-manifest.ts and scripts/check-stale-adr-references.ts exist and both run as clean-clone-builds steps in ci.yml, and CONTRIBUTING.md states the class-3 expectation. Item 6 is done here: AGENTS.md's qualifier now reads accepted. Items 5 and 7 stay open, as the record's own class-3 rule asks. MANIFEST.md regenerated by `bun run emit:manifest`. Signed-off-by: Mark Beacom <m@beacom.dev>
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The status, provenance, generated inventory, and public qualifier are consistent.
Review effort: Balanced
Findings: None
What changed in this PR
Accepts ADR-0040 and synchronizes its derived/public status references.
Changes:
- Marks ADR-0040 accepted with ratification provenance.
- Updates its action item and public qualifier.
- Regenerates the ADR inventory consistently.
The adrkit decision-context MCP was unavailable, so marker-only governance was not independently verified.
| File | Description |
|---|---|
MANIFEST.md |
Updates generated status counts and ADR-0040 entry. |
docs/adr/0040-*.md |
Records acceptance, ratification, and completed qualifier update. |
AGENTS.md |
Changes ADR-0040’s public qualifier to accepted. |
Decisions governing this change
|
This was referenced Sep 30, 2026
mbeacom
added
documentation
mbeacom
enabled auto-merge (squash)
September 30, 2026 23:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
ADR-0040 is now
accepted(ratifiedBy: @mbeacom).I reviewed it against every record it relates to (0004, 0005, 0007, 0008, 0016, 0022, 0023, 0031, 0033, 0039) and against the three recorded after it (0041–0043). None conflicts. It cites 0005, which is superseded, but the record already routes that citation to its successor, ADR-0027.
scripts/emit-manifest.tsandscripts/check-stale-adr-references.tsexist, and both run asclean-clone-buildssteps inci.yml.CONTRIBUTING.md§4 states the class-3 expectation.(**proposed**)qualifier inAGENTS.mdnow reads accepted. A path-glob search found no other public qualifier naming 0040.MANIFEST.mdregenerated withbun run emit:manifest. The decision text is unchanged; the edits are status, provenance, and one checkbox.Checklist
packages/ci/dist: n/a (docs only)adr lint(43 records) andcheck:stale-refspass, and thescripts/suite passes.Notes for reviewers
Merge this before the
adr acceptPR. Both editMANIFEST.mdand the sameAGENTS.mdsection, so that PR will be rebased onto this one.