Repository navigation
Conversation
Collaborator
Author
|
Closing: no corrective revert is needed; #982's merged state remains the forward baseline. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the merged benchmark workflow change to its intended scope by removing the benchmark-browser UI follow-up that was accidentally included in PR #982. This returns the six affected browser and documentation files exactly to their pre-browser state while retaining all local backfill, upload, dataset, and fixture-design work from #982.
The browser improvements are preserved separately and will be proposed from a dedicated follow-up branch after this correction lands.
AG;DR
71e13724c0andafd0e0d4eb, which added and formatted the benchmark-browser card changes.e347000f91andcb2d0b92a3, which are the intended benchmark workflow and fixture-design scope of Improve local benchmark backfill and upload workflow #982.docs/benchmark-comparisons.mdtools/benchmark_landscape.pytools/benchmark_landscape_test.pytools/benchmark_web/history.jstools/benchmark_web/landscape.jstools/benchmark_web/landscape.test.mjscb2d0b92a3, immediately before the browser follow-up commits.Validation:
bazel test //tools:benchmark_landscape_testgit diff --checkKnown limitation: the already-merged history of #982 cannot be rewritten safely. This corrective change restores
mainsemantically; the browser work will then have its own reviewable PR and history.