Skip to content

fix: MouseMixin targets onButton on NeoForge 1.21.5+ (fixes 1.21.11 startup crash) #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KoSHeroff merged 2 commits into from
Jul 26, 2026
Merged

fix: MouseMixin targets onButton on NeoForge 1.21.5+ (fixes 1.21.11 startup crash) #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d254e58
fix: inject MouseHandler.onButton on NeoForge 1.21.5+
KoSHeroff Jul 26, 2026
dcefab6
release: 1.6.1
KoSHeroff Jul 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
# Changelog

## 1.6.1 - 2026-07-26

### Fixed
- Fixed a NeoForge 1.21.11 startup crash: `MouseMixin` still targeted the removed `MouseHandler.onPress`; it now injects into `onButton` on 1.21.5+.

## 1.6.0 - 2026-07-25

### Added
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ org.gradle.jvmargs=-Xmx4G
org.gradle.parallel=true
dev.kikugie.stonecutter.hard_mode=true

mod_version=1.6.0
mod_version=1.6.1
maven_group=land.webgui
archives_base_name=webgui

Expand Down
6 changes: 3 additions & 3 deletions src/main/java/land/webgui/mixin/MouseMixin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
//? } else {
/*import net.minecraft.client.Minecraft;
import net.minecraft.client.MouseHandler;
//? if >=26 {
//? if >=1.21.5 {
import net.minecraft.client.input.MouseButtonInfo;
//? }*/
//? }
Expand All @@ -36,7 +36,7 @@ public class MouseMixin {
@Inject(method = "onMouseButton", at = @At("HEAD"), cancellable = true)
private void webgui$cancelVanillaForWebHudPseudoGui(long window, MouseInput input, int action, CallbackInfo ci) {
//? } else {
/*//? if >=26 {
/*//? if >=1.21.5 {
@Inject(method = "onButton", at = @At("HEAD"), cancellable = true)
private void webgui$cancelVanillaForWebHudPseudoGui(long window, MouseButtonInfo rawButtonInfo, int action, CallbackInfo ci) {
//? } else {
Expand Down Expand Up @@ -106,7 +106,7 @@ public class MouseMixin {
browser.sendMouseRelease(lx, ly, input.button());
}
//? } else {
/*//? if >=26 {
/*//? if >=1.21.5 {
if (action == GLFW.GLFW_PRESS) {
browser.sendMousePress(lx, ly, rawButtonInfo.button());
} else if (action == GLFW.GLFW_RELEASE) {
Expand Down
Loading