Fix Chrome support data for MediaStreamTrack.applyConstraints - #30320
Closed
BHUVANSH855 wants to merge 1 commit into
Closed
BHUVANSH855 wants to merge 1 commit into
BHUVANSH855 wants to merge 1 commit into
Conversation
github-actions
Bot
added
data:api
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
requested changes
Sep 3, 2026
Comment on lines
+50
to
+51
| "partial_implementation": true, | ||
| "notes": "`echoCancellation` does not always take effect when used with `applyConstraints()`." |
Contributor
There was a problem hiding this comment.
In the issue I wrote:
For Chrome, if
applyConstraints()withechoCancellationnever has an effect, we should set version_added to false here
Is there evidence that this ever has an effect? Then the notes should mention when it works, and when it doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update Chrome compatibility data for
MediaStreamTrack.applyConstraints()to reflect partial implementation when applying theechoCancellationconstraint.Test results and supporting details
git diff --check✅npm run format✅npm run lint✅Related issues
Fixes #25717