Remove obsolete CSS features and enable obsolescence lint for CSS - #30478
Open
Elchi3 wants to merge 1 commit into
Open
Remove obsolete CSS features and enable obsolescence lint for CSS#30478Elchi3 wants to merge 1 commit into
Elchi3 wants to merge 1 commit into
Conversation
Contributor
|
Tip: Review these changes grouped by change (recommended for most PRs), or grouped by feature (for large PRs). |
caugner
approved these changes
Sep 11, 2026
caugner
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I would reframe the PR title to removing these obsolete CSS features.
Not mandatory, but with PR stacks you could have the bottom PR removing the obsolete CSS features, another one on top that updates the non-obsolete CSS features, and a third one that removes the obsolete lint. This is slightly more work when doing these changes all manually, but simplifies the reviews, and allows to merge them all together (in three separate commits) when all are approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Right now, our irrelevance guideline is not applied to the
css/folder because the lint has been disabled (from the start when we first implemented this rule, there were just too many data points to clean up at the time). We're now down to 25 entries there and I think it is time to finally enable this lint for CSS, too.If you enable the lint on main you get the following messages:
I removed all of these except for:
Test results and supporting details
Improved linting now passes for the CSS folder.
Future lints will prevent authors from adding all-false CSS features.
Related issues
None, I think.