Skip to content

fix(claude-lane-outcome): classify a review step with no execution file as its own failure class #657

Description

@kyle-sexton

claude-lane-outcome reports a review step that produced no execution file as failure-class=other, so a review that hit the step timeout reads as "an unclassified failure; read the job log".

Evidence

Proposed

  1. In classify.cjs, return a separate class (for example no-execution) for a non-success outcome that has no execution file. A step timeout reports outcome: failure, the same as an early crash, so the name should cover both.
  2. Add a matching case arm to the status step in claude-review.yml and claude-security-review.yml, for example "the review step produced no output before it ended (likely the step timeout); re-run the job". Keep exit 1, so a PR never looks reviewed when no review ran.
  3. Update the failure-class output descriptions, and add a test for the new class wherever classify.cjs is tested.
  4. Optional: lower the security-review step timeout from 14 to about 10 min. In claude-code-plugins, its 55 most recent successful runs took p95 221 s and max 294 s. The code-review step's 59 successful runs took p95 355 s and max 392 s, so its 11 min timeout stays as it is.

🤖 Generated with Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageNot yet classified. Floor until a type and one priority tier are set.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions