chore: remove docs/topics - #650
Conversation
Durable plans and specs live in the pull request body and the linked issue, so the docs/topics tree and the references that required it go. Refs: melodic-software/claude-code-plugins#5575 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
claude-security-review has reviewed this pull request through f0b5345; a later push is reviewed from there. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 2m 9s —— View job Code review —
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f0b53451e2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1,103 +0,0 @@ | |||
| # ADR — CI fan-out consolidation (#122) | |||
There was a problem hiding this comment.
When the selector-contract job next runs (for example, after any .github/** or .node-version change), .github/scripts/ci-fanout-consolidation.test.cjs still reads this exact path at module initialization, so node --test .github/scripts/*.test.cjs exits with ENOENT and the aggregated ci-status check fails. Update or remove the ADR assertions as part of deleting this document.
Useful? React with 👍 / 👎.
| @@ -1,135 +0,0 @@ | |||
| # Claude review lanes — V2 plugin architecture | |||
There was a problem hiding this comment.
The V2 architecture doc exists and names both skills case in .github/scripts/claude-review-plugin-path.test.cjs still calls readFileSync on this file, so every future run of the selector-contract suite fails with ENOENT. Remove or replace that documentation assertion together with this deletion.
Useful? React with 👍 / 👎.
|
claude-review has reviewed this pull request through f0b5345; a later push is reviewed from there. |
No related issue: main has been red since c11c7ec (#650); this restores it. ## Summary #650 deleted `docs/topics/` while #656 added two AGENTS.md links into it, and two tests still read files there. `lychee-offline` and `selector-contract` fail on `main` and on every open PR. ## Fix - AGENTS.md: the two Code Review Rules lines that linked into `docs/topics/` now state their rule inline. - `.github/scripts/ci-fanout-consolidation.test.cjs`: drop the ADR read and the test that asserted the ADR's text. - `.github/scripts/claude-review-plugin-path.test.cjs`: drop the test that asserted the V2 architecture doc's text. ## Verification - `node --test .github/scripts/*.test.cjs`: 192 pass, 0 fail. - `git grep docs/topics` finds only the standards-managed `.github/actionlint.yaml` comment that #650 already noted. ## Related - Unblocks #659. - Cause: #650 and #656 merged in parallel. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: first CI lane of the automation-lanes effort, planned in a local decision brief. **Hold: a human merges this.** It adds a lane that holds a secret and `issues: write`, so it is a lane-power change; the babysit lane must not merge it. ## Summary Adds `.github/workflows/claude-intake-triage.yml`, a reusable workflow that triages a newly opened issue: a read-only Claude run proposes labels and a comment, and a step with no model validates and applies them. README gains its entry. ## Fix - Claude runs with `--permission-mode dontAsk`, tools `Read,Grep,Glob,Bash`, Bash approved only for `gh issue view/list`, `gh search issues`, `gh label list`, and `--json-schema` output whose label enum is the caller's `allowed-labels` intersected with the repository's live labels. - `allowed_non_write_users: "*"` with the job `GITHUB_TOKEN`, so outside reporters are triaged (the action then scrubs subprocess secrets and keeps `.git/config` token-free). - The apply step keeps only allowlisted, existing labels (`addLabels` would otherwise create unknown ones), breaks @mentions, withholds a comment matching a credential pattern, and applies `escalation-label` (default `needs-human`) on any permission denial, a max-turns stop, or `needs_human: true`. - The CLI is installed at run time and passed through `path_to_claude_code_executable` (`cli-version` input, else the `CLAUDE_LANE_CLI_VERSION` variable, else `latest`; `bundled` keeps the action's own). The step summary records the installed version and the npm-published latest. - Job `claude-intake-triage-status` goes red on a failed run; it is advisory and must never be required. ## Verification - `actionlint` and `zizmor --offline`: no findings. - `node --test .github/scripts/*.test.cjs`: 183 pass, 2 fail; both failures (`ci-fanout-consolidation`, `V2 architecture doc exists`) read files under `docs/topics/`, which #650 removed, and fail on `main` too. The outcome-wiring test now covers this lane. - Local probes on Claude Code CLI 2.1.288: `dontAsk` denied Read of `/etc/hostname` and `/proc/self/status` and recorded both in `permission_denials` while reading a file in the working directory; `--tools` restricted to `Read,Grep,Glob,Bash` plus `--json-schema` with a label enum returned valid `structured_output`. - Not yet run end to end: that needs the standards runner-policy contract for the merged SHA and a synced caller; the pilot on claude-code-plugins includes a prompt-injection canary issue. ## Related - Pattern mirrored: `claude-review.yml` (outcome composite, status job). - Coexists with `issue-triage-label.yml` (deterministic `needs-triage` floor). - Next: standards `runner-policy` contract and caller component, then the claude-code-plugins pilot. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 participant
Refs: melodic-software/claude-code-plugins#5575
Summary
Removes the
docs/topicstree. Durable plans and specs now live in the pull request body and the linked issue (owner decision on melodic-software/claude-code-plugins#5575, option A).Fix
git rm -r docs/topics; drop the README pointer to docs/topics/local-lane-guards.md.
Verification
git ls-tree -r HEAD docs/topicsis empty andgit grep -nIE 'docs/topics|topic-docs|contract-slice'finds nothing that this change owns (exceptions in Related).Related
.github/actionlint.yamlis a standards-managed file; its comment still names a deleted ci-workflows plan path until the standards PR for this issue syncs down. Not edited here so the managed-files guard stays green.