Skip to content

playbooks: repo-sweep tidy entry takes one lane, so a sweep cannot tidy every lane in a repo #4535

Description

@kyle-sexton

Problem

The hygiene catalog's tidy entry has args: <lane> and applies-when "repo has source code and the user wants one tidying lane in this sweep". code-tidying:tidy runs one lane per invocation, so the entry can only ever cover one slice of a repo.

In the melodic-software/.github sweep (PR melodic-software/.github#153, step commit 5fc82af) the user asked to tidy all of it. That meant three lanes: shell-tooling, docs-prose, and an ad hoc scope for .github/scripts/*.mjs, which has no lane at all. The session ran one tidy dry-run per lane by hand, merged the findings, and recorded the split in the step commit's scope decisions. None of that is in the catalog or in reference/next.md.

Proposed fix

  • Let the entry take a list of lanes, or all to mean every lane that matches the repo, and have next run tidy once per lane inside the one step.
  • Rewrite applies-when to match, for example "repo has source code or prose that at least one tidy lane covers".
  • State in the entry's notes that the findings from every lane go to the user for review together, and that one step commit covers all of them.

Related

Separate from #4503, which is about tidy owning its own branch, PR, and commit structure.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EYihoan7ULtdu32i34NaTq

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-triageNot yet classified. Floor until a type and one priority tier are set.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions