Problem
skills/audit/context/persist-findings.md says to resolve the producer contract with the review plugin's bundled copy first (rung 1, "works offline"), then to follow the contract's "Where the file goes" rung order. The bundled copy, review/reference/findings-file-shape.md (checked at 0.30.4), has no "Where the file goes" section. The destination rules live only in docs/conventions/detector-findings/README.md in this repository, which is rung 2, a network fetch, plus review/reference/topic-docs.md.
So rung 1 cannot resolve the destination, and an offline run has no rule for where to write.
Evidence
melodic-software/.github#153, provenance step: grep -i 'where the file goes' on the bundled copy returns nothing. The run fell back to fetching the raw convention URL.
Fix
Point persist-findings.md rung 1 at review/reference/topic-docs.md "Resolution" for the destination, or ship the destination rules in the bundled copy.
Problem
skills/audit/context/persist-findings.mdsays to resolve the producer contract with thereviewplugin's bundled copy first (rung 1, "works offline"), then to follow the contract's "Where the file goes" rung order. The bundled copy,review/reference/findings-file-shape.md(checked at 0.30.4), has no "Where the file goes" section. The destination rules live only indocs/conventions/detector-findings/README.mdin this repository, which is rung 2, a network fetch, plusreview/reference/topic-docs.md.So rung 1 cannot resolve the destination, and an offline run has no rule for where to write.
Evidence
melodic-software/.github#153,
provenancestep:grep -i 'where the file goes'on the bundled copy returns nothing. The run fell back to fetching the raw convention URL.Fix
Point
persist-findings.mdrung 1 atreview/reference/topic-docs.md"Resolution" for the destination, or ship the destination rules in the bundled copy.