Skip to content

playbooks repo-sweep: add a "filed" step outcome for findings fixed in another repo #5174

Description

@kyle-sexton

Problem

A repo-sweep step can end with a real finding whose fix belongs in another repository. tick.sh has only two done outcomes, committed <sha> and no-findings, so such a step has to be recorded as no findings, which is false.

Observed in the melodic-software/.github hygiene sweep (melodic-software/.github#153), step progressive-disclosure: the audit found that .claude/rules/pr-body-contract.md loads every session but matters only at PR time. The file is sync-managed from melodic-software/standards, so the fix was filed there (melodic-software/standards#641) and nothing changed locally. The checklist now reads:

- [x] progressive-disclosure: docs-hygiene:audit-progressive-disclosure@0.23.1, no findings

history.sh and any reader of past sweep PRs will treat that step as a clean pass, and the upstream issue is linked nowhere in the sweep record.

Proposed fix

  • tick.sh <id> filed <issue-url> <skill@version>... writing - [x] <id>: <skill@version, ...>, filed <issue-url>.
  • Accept , filed <url> as a done suffix wherever , committed <sha> / , no findings are matched (tick.sh line 58, state.sh, history.sh).
  • reference/next.md section 4: when the agreed fix lives in another repository, file the issue there after user approval and tick with filed.
  • Decide whether history.sh should recommend rerun for a filed step once the issue closes.

Acceptance

  • A step with only upstream-filed findings can be ticked done with the issue URL in the checklist line.
  • state.sh treats that line as done and moves to the next step.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readyFully specified and briefed; eligible for autonomous pickup from the frontier.priority: lowNice-to-have, cosmetic, or speculative; opportunistic.status: readyTriaged, unblocked, and fully specified; eligible to pick up.work-class: scopedA briefed fix or small feature; blast radius bounded by the brief, tests exist.

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions