Skip to content

fix(ci): do-not-merge is not enforced on merge_group runs #5952

Description

@kyle-sexton

Problem

After #5935, ci.yml runs on merge_group. There pr-contract reports skipped because the event carries no PR, so a do-not-merge label added after a PR enters the merge queue does not eject it. This becomes live once the github-iac merge-queue ruleset (melodic-software/github-iac#583) is applied.

Evidence

  • .github/workflows/ci.yml:53 (merge_group trigger); ci-status reads the label only from the PR event.

Suggested fix

Pick one:

  1. Document that the operator removes the PR from the queue after applying do-not-merge.
  2. Parse the PR number from merge_group.head_ref (gh-readonly-queue/<base>/pr-<N>-<sha>) and check its labels. The format is documented only by prefix, and this covers only the newest PR in a group.

Found while working on #5935.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-humanHuman-in-the-loop required; autonomous sessions must not resolve items carrying this.priority: highSignificant impact, or blocks an imminent release; staff this cycle.status: needs-decisionAwaiting a human or maintainer judgment call.work-class: structuralRefactors, migrations, contract changes; cross-cutting and hard to reverse.

    Type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions