Problem
The references say behind is a hard stop, but compute_branch_freshness only runs the compare when mergeStateStatus is BLOCKED. A CLEAN head that is behind its base under a non-strict ruleset is therefore not held. A merge queue would make this moot for queue bases. Pre-existing.
Evidence
- plugins/source-control/skills/babysit-prs/scripts/babysit_delta.py:233 (
compute_branch_freshness).
Suggested fix
Run the compare for CLEAN heads too (or whenever the base is not queue-managed), and hold when behind.
Found while working on #5935.
Problem
The references say
behindis a hard stop, butcompute_branch_freshnessonly runs the compare whenmergeStateStatusisBLOCKED. A CLEAN head that is behind its base under a non-strict ruleset is therefore not held. A merge queue would make this moot for queue bases. Pre-existing.Evidence
compute_branch_freshness).Suggested fix
Run the compare for CLEAN heads too (or whenever the base is not queue-managed), and hold when behind.
Found while working on #5935.