Context
Found while delivering spec container #5835. review:explain-change landed in #6018 with a digest_policy setting (always, offer, and others).
Problem
The pull-request ready flow in source-control never invokes review:explain-change. With digest_policy set to always or offer, nothing runs at ready time, so the policy has no caller and the digest is never produced or offered.
Suggested fix
Have /source-control:pull-request ready read the resolved digest_policy after the merge-base, review and verify steps and, before it flips the PR, call review:explain-change (always) or offer it (offer). Add a test for each policy value.
Related: #5835
Context
Found while delivering spec container #5835.
review:explain-changelanded in #6018 with adigest_policysetting (always,offer, and others).Problem
The
pull-request readyflow insource-controlnever invokesreview:explain-change. Withdigest_policyset toalwaysoroffer, nothing runs at ready time, so the policy has no caller and the digest is never produced or offered.Suggested fix
Have
/source-control:pull-request readyread the resolveddigest_policyafter the merge-base, review and verify steps and, before it flips the PR, callreview:explain-change(always) or offer it (offer). Add a test for each policy value.Related: #5835