Skip to content

chore(attribution): drop the temporary settings enablement - #5430

Draft
kyle-sexton wants to merge 2 commits into
mainfrom
chore/4668-revert-attribution-settings-line
Draft

kyle-sexton wants to merge 2 commits into
mainfrom
chore/4668-revert-attribution-settings-line

Conversation

@kyle-sexton

Copy link
Copy Markdown
Contributor

Refs #4668

Summary

.claude/settings.json carried attribution@melodic-software: true as a temporary enablement, because the fleet plugin list in standards still named the old provenance@melodic-software id. Once standards enables attribution@melodic-software (melodic-software/standards#654), the fleet list covers it and this line is redundant.

Fix

  • Remove "attribution@melodic-software": true from enabledPlugins in .claude/settings.json.
  • Add "provenance@melodic-software": false, in byte-sorted position. The catalog still ships the deprecated plugins/provenance shim, and scripts/check-plugin-catalog-enablement.sh fails on a catalogued plugin that neither the fleet list nor settings names. An explicit false is a recorded decision and passes the gate.

Not touched, per the owner decision on #4668: the renames map in .claude-plugin/marketplace.json, and the plugins/provenance shim (removed in a later release).

Verification

  • PLUGIN_CATALOG_ENABLEMENT_FLEET=<fleet-plugins.json from standards#654> bash scripts/check-plugin-catalog-enablement.sh exits 0 (83 catalogued plugins covered, none orphaned, keys sorted).
  • Without the provenance key the same run fails, so the explicit false is needed.
  • bash scripts/check-plugin-catalog-enablement.test.sh: PASS=19 FAIL=0.
  • .claude/settings.json parses as JSON.
  • Against current standards main (which still names provenance@melodic-software), the gate would pass only with the attribution line present. This PR must not merge before standards#654 lands; it stays a draft until then.

Related

🤖 Generated with Claude Code

Remove the attribution@melodic-software enablement from .claude/settings.json;
the fleet plugin list carries it. The catalog still ships the deprecated
provenance shim, so record it as an explicit false to keep
check-plugin-catalog-enablement.sh passing.

Refs #4668

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

PR body contract — issue linkage

This PR body does not yet satisfy the issue-linkage contract:

  • Missing a native closing keyword (Closes/Fixes/Resolves #N). If this PR references an issue it must not close, put "Refs: #N" (or "Relates to: #N") on its own line. If it relates to no GitHub issue at all, state "No linked issue" (or "No related issue:") in the body instead.

Edit the body and this comment updates itself on the next run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant