chore(attribution): drop the temporary settings enablement - #5430
Draft
kyle-sexton wants to merge 2 commits into
Draft
kyle-sexton wants to merge 2 commits into
kyle-sexton wants to merge 2 commits into
Conversation
Remove the attribution@melodic-software enablement from .claude/settings.json; the fleet plugin list carries it. The catalog still ships the deprecated provenance shim, so record it as an explicit false to keep check-plugin-catalog-enablement.sh passing. Refs #4668 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
PR body contract — issue linkage This PR body does not yet satisfy the issue-linkage contract:
Edit the body and this comment updates itself on the next run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #4668
Summary
.claude/settings.jsoncarriedattribution@melodic-software: trueas a temporary enablement, because the fleet plugin list in standards still named the oldprovenance@melodic-softwareid. Once standards enablesattribution@melodic-software(melodic-software/standards#654), the fleet list covers it and this line is redundant.Fix
"attribution@melodic-software": truefromenabledPluginsin.claude/settings.json."provenance@melodic-software": false, in byte-sorted position. The catalog still ships the deprecatedplugins/provenanceshim, andscripts/check-plugin-catalog-enablement.shfails on a catalogued plugin that neither the fleet list nor settings names. An explicitfalseis a recorded decision and passes the gate.Not touched, per the owner decision on #4668: the renames map in
.claude-plugin/marketplace.json, and theplugins/provenanceshim (removed in a later release).Verification
PLUGIN_CATALOG_ENABLEMENT_FLEET=<fleet-plugins.json from standards#654> bash scripts/check-plugin-catalog-enablement.shexits 0 (83 catalogued plugins covered, none orphaned, keys sorted).provenancekey the same run fails, so the explicitfalseis needed.bash scripts/check-plugin-catalog-enablement.test.sh: PASS=19 FAIL=0..claude/settings.jsonparses as JSON.main(which still namesprovenance@melodic-software), the gate would pass only with theattributionline present. This PR must not merge before standards#654 lands; it stays a draft until then.Related
enabledPluginsupdates, the~/.claude/plugins/data/provenance-melodic-software/empty-check, and shim removal remain owner actions).🤖 Generated with Claude Code