feat(planning): nudge on a surface note that ends mid-sentence - #5491
Conversation
The decide row already nudges an own answer ending in "?". It now also shows a non-blocking "looks cut off" nudge when the note ends mid-sentence, reusing midSentence. Saving stays enabled. Refs #5454 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d note Adds the negative browser check beside the cut-off nudge check and corrects the SKIP count for the browser checks. Refs #5454 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-off-note-nudge # Conflicts: # plugins/planning/.claude-plugin/plugin.json # plugins/planning/CHANGELOG.md
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude encountered an error after 0s —— View job I'll analyze this and get back to you. |
|
Claude encountered an error after 1s —— View job I'll analyze this and get back to you. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ab8f96ee6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 6s —— View job Security review (
|
|
Claude finished @kyle-sexton's task in 2m 2s —— View job Code review complete
No high-signal findings. I reviewed all 6 changed files ( Notes from the review (none rose to a blocking finding):
Verification of 🤖 Generated with Claude Code |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 2m 10s —— View job Code review complete
No high-signal findings. Reviewed all 6 changed files ( Notes from the review (none rose to a blocking finding, no inline comments posted):
Security aspects (XSS via the new static nudge string, ReDoS in 🤖 Generated with Claude Code |
|
Claude finished @kyle-sexton's task in 41s —— View job Security review complete
Scope: all 6 changed files at HEAD Result: no security issues found. Notes from the review:
No inline comments posted since there are no findings. |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 20s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: this head's diff is textually identical to the one already covered by the prior security-review pass on this PR (commit Re-confirmed scope: all 6 changed files (
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 47s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files (
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 1m 20s —— View job Code review complete
Skip gate criterion 4 applies: this lane already posted a successful code-review pass on this PR at commit No new findings to report. The prior pass's notes stand:
Security aspects (static nudge string, |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 45s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files (
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 1m 30s —— View job Code review complete
Skip gate criterion 4 applies: this lane already posted a successful code-review pass on this PR at commit No new findings to report. The prior pass's notes stand:
Security aspects (static nudge string, |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 58s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files (
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 1m 35s —— View job Code review complete
Skip gate criterion 4 applies: this lane already posted a successful code-review pass on this PR at commit No new findings to report. The prior pass's notes stand:
Security aspects (static nudge string, |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 4s —— View job Code review complete
Skip gate criterion 4 applies: this lane already posted a successful code-review pass on this PR at commit
No new findings to report. The prior pass's notes stand:
Security aspects (static nudge string, |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 0s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD
Re-confirmed scope for completeness, all 6 changed files at HEAD
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 49s —— View job Code review complete
Skip gate criterion 4 applies: this lane already posted a successful code-review pass on this PR at commit
No new findings to report. The prior pass's notes stand:
Security aspects (static nudge string, |
|
Claude finished @kyle-sexton's task in 44s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files (
No inline comments posted since there are no findings. |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 47s —— View job Code review complete
Skip gate criterion 4 applies: this lane already posted a successful code-review pass on this PR at commit No new findings to report. The prior pass's notes stand:
Security aspects (static nudge string, |
|
Claude finished @kyle-sexton's task in 40s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 43s —— View job Code review complete
Skip gate criterion 4 applies: this lane has already posted multiple successful code-review passes on this PR (most recently at commit I diffed
No new findings to report; the prior passes' notes stand (relocated |
|
Claude finished @kyle-sexton's task in 1m 2s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 44s —— View job Code review complete
Skip gate criterion 4 applies: this lane has already posted multiple successful code-review passes on this PR, most recently at commit I diffed
No new findings to report; the prior passes' notes stand (relocated |
|
Claude finished @kyle-sexton's task in 35s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 51s —— View job Code review complete
Skip gate criterion 4 applies: this lane has already posted numerous successful code-review passes on this PR (most recently at commit I fetched the current PR diff (
No new findings to report. The prior passes' notes stand: the relocated |
|
Claude finished @kyle-sexton's task in 1m 3s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 35s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 46s —— View job Code review complete
Skip gate criterion 4 applies: this lane has already posted numerous successful code-review passes on this PR, most recently at commit I fetched the current PR diff (
No new findings to report. The prior passes' notes stand: the relocated |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 11s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 47s —— View job Code review complete
Skip gate criterion 4 applies: this lane has already posted numerous successful code-review passes on this PR, most recently at commit I diffed
No new findings to report. The prior passes' notes stand: the relocated |
…-off-note-nudge Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 50s —— View job Security review complete
Result: no security issues found. Skip-gate criterion 3 applies: HEAD
Re-confirmed scope: all 6 changed files at HEAD
No inline comments posted since there are no findings. |
|
Claude finished @kyle-sexton's task in 55s —— View job Code review complete
Skip gate criterion 4 applies: this lane has already posted numerous successful code-review passes on this PR, most recently at commit I diffed
No new findings to report. The prior passes' notes stand: the relocated |
Closes #5454
Summary
The interview surface saved an answer note that stopped mid-sentence without a word. Only the Loose ends wrap-up check used
midSentence.Fix
plugins/planning/surface/index.html:midSentencemoved aboverenderAnswer; the decide row shows a non-blocking "This note looks cut off. Finish it before saving?" nudge (#cutNudge) beside the existing?nudge. A note ending in?keeps only the Ask Claude nudge.plugins/planning/skills/interview/context/surface.md: states the new nudge.plugins/planning/surface/tests/ui_journey.jsandsurface.test.sh: a check that the nudge shows on a cut-off note and not on a finished one; SKIP counts updated.planning0.47.0 to 0.48.0 with a CHANGELOG entry.Verification
bash plugins/planning/surface/surface.test.sh(browser suites ran, after merging origin/main): PASS=290 FAIL=0 SKIP=1scripts/check-changelog-parity.sh --check --check-order: passedscripts/validate-plugins.sh: all manifests and the catalog validatedRelated
Parent umbrella: #5191.
🤖 Generated with Claude Code