fix(disk-hygiene): add model-invocable /disk-hygiene:check and name it in the missing-Python notice - #5615
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 2m 42s —— View job Security review — PR #5615
Scope reviewed (all 9 changed files, diffed against No security issues found. Notes from the pass:
|
|
Claude finished @kyle-sexton's task in 2m 49s —— View job Code review complete
SummaryReviewed the diff against 1 finding posted inline on The new skill's
Since this skill is meant to run without a permission prompt (that's the whole point of making it model-invocable instead of routing through the manual claude-code-plugins/plugins/disk-hygiene/skills/check/SKILL.md Lines 5 to 12 in bf9f4e8 Everything else in the diff (hook fix, tests, docs, registry, CHANGELOG/version bump) looked correct and consistent; I didn't find other issues meeting the high-signal bar. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf9f4e8e0e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…owed-tools Wildcarded python/py rules grant nothing under auto mode and trip the permission-rule-hygiene P1 check, so the probes run under the session's normal permissions. Merges origin/main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 2m 17s —— View job Code review complete
SummaryReviewed the diff against 1 finding posted inline on
Everything else in the diff (hook fix, tests, docs, registry, CHANGELOG/version bump) looked Verification: I was not able to run the author's cited commands |
|
Claude finished @kyle-sexton's task in 2m 38s —— View job Security review — PR #5615 (re-run at
|
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 8s —— View job Security review — PR #5615 (re-run at
|
|
Claude finished @kyle-sexton's task in 53s —— View job Code review complete
SummaryThis run was triggered by a Per the lane's skip gate ("this head already has a successful review from this lane that still
No new inline comments posted since no new lines changed. If a future push touches |
…37.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 2s —— View job Security review — PR #5615 (re-run at
|
|
Claude finished @kyle-sexton's task in 1m 9s —— View job Code review complete
SummaryThis run was triggered by a Per the lane's skip gate ("this head already has a successful review from this lane that still
The unscoped No new inline comments posted since no line in the reviewed set changed. |
…used git probe The check flow only runs `grep -m1 '^MIN_PYTHON'` and `command -v git`, so the grep grant is anchored to that pattern and `git --version` is removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 1m 5s —— View job Code review complete
SummaryThis run was triggered by a - - "Bash(git --version*)"
- - "Bash(grep -m1 *)"
+ - "Bash(grep -m1 '^MIN_PYTHON' *)"Verified against
No other lines changed in this commit, and no new issues were introduced by the fix. No findings to report. Everything flagged across this PR's prior rounds (both lanes) is now |
|
Claude finished @kyle-sexton's task in 48s —— View job Security review — PR #5615 (re-run at
|
…38.0 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Claude finished @kyle-sexton's task in 54s —— View job Security review — PR #5615 (re-run at
|
|
Claude finished @kyle-sexton's task in 1m 13s —— View job Code review complete
SummaryThis run was triggered by a mention on the PR at head I diffed each of those files between allowed-tools:
- "Bash(command -v *)"
- "Bash(grep -m1 '^MIN_PYTHON' *)"with both previously-open findings — the dead Per the lane's skip gate ("this head already has a successful review from this lane that still No findings to report. |
Closes #5436
Summary
The missing-Python hook notice in disk-hygiene told the user to run
/disk-hygiene:setup check, which carriesdisable-model-invocation: true, so Claude could not run it.docs/plugin-philosophy.mdsays a hook or probe names/<plugin>:checkinstead.Fix
plugins/disk-hygiene/skills/check/SKILL.md(with evals): a model-invocable, read-only probe that reads setup'schecksection and installs nothing._NO_PYTHON_FIXinhooks/run-python-hook.shnow ends with/disk-hygiene:check; the two assertions inrun-python-hook.test.shfollow.docs/skill-cheat-sheet.mdandscripts/skill-leaf-name-registry.txtlist the new skill.Verification
bash plugins/disk-hygiene/hooks/run-python-hook.test.sh: PASS, all run-python-hook contract checks.scripts/validate-plugins.sh: all plugin manifests and the catalog validated.scripts/check-changelog-parity.sh --check,--check-order,--check-bump origin/main: all pass.Related
Refs #4240, #5377 (the rule this notice now follows).
🤖 Generated with Claude Code