Repository navigation
feat(animation): report a missing node once per session with a SessionStart node-notice row #6081
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
fa8f389
feat(animation): report a missing node once per session with a Sessio…
kyle-sexton 63a16d8
fix(animation): give check-prerequisites its evals and a one-line Next
kyle-sexton 34ac2cd
Merge remote-tracking branch 'origin/main' into feat/5843-animation-n…
kyle-sexton e2e8ab9
fix(animation): point the manifest checks at check-prerequisites and …
kyle-sexton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| --- | ||
| description: "Read-only report of whether the external tools the animation plugin declares in prerequisites.json resolve, through the shared Node checker. /animation:setup is the fuller setup report; this skill is the shared checker's. Use when: 'animation node notice', 'is animation ready', a hook notice says node is missing. It does not verify the hook-installed Python packages; /animation:setup does. Does not install." | ||
| user-invocable: true | ||
| disable-model-invocation: false | ||
| metadata: | ||
| workflow-stage: anytime | ||
| summary: Report whether the tools animation declares resolve. Never installs. | ||
| --- | ||
|
|
||
| ## Purpose | ||
|
|
||
| Run the read-only check. Do not install anything, and do not edit `prerequisites.json`. | ||
|
|
||
| The plugin has no `check` skill, so the prerequisites check has its own name. A hook notice names it. | ||
|
|
||
| ## Check | ||
|
|
||
| Run the shared checker through its stub, which reports a missing `node` instead of failing to start: | ||
|
|
||
| ```bash | ||
| sh "${CLAUDE_PLUGIN_ROOT}/lib/prerequisites.sh" check "${CLAUDE_PLUGIN_ROOT}" --data-dir "${CLAUDE_PLUGIN_DATA}" | ||
| ``` | ||
|
|
||
| Where there is no `sh` (Windows without Git Bash), run the PowerShell stub with the same arguments instead: | ||
|
|
||
| ```powershell | ||
| powershell -NoProfile -ExecutionPolicy Bypass -File "${CLAUDE_PLUGIN_ROOT}/lib/prerequisites.ps1" check "${CLAUDE_PLUGIN_ROOT}" --data-dir "${CLAUDE_PLUGIN_DATA}" | ||
| ``` | ||
|
|
||
| Report the PASS/FAIL rows as a table. On a FAIL, give the install hints the checker printed. Stop. | ||
|
|
||
| ## Next | ||
|
|
||
| /animation:setup | ||
|
|
||
| ## Gotchas | ||
|
|
||
| This skill does not install. A hook notice is not permission to install Node.js. | ||
41 changes: 41 additions & 0 deletions
41
plugins/animation/skills/check-prerequisites/evals/evals.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| { | ||
| "skill_name": "check-prerequisites", | ||
| "evals": [ | ||
| { | ||
| "id": 1, | ||
| "name": "node-notice-runs-the-check", | ||
| "prompt": "A session-start notice said node is missing for animation. What else is missing?", | ||
| "expected_output": "Runs the shared checker through lib/prerequisites.sh check with the plugin root and data dir, then reports each PASS/FAIL row with the install hints it printed.", | ||
| "files": [], | ||
| "expectations": [ | ||
| "Runs `lib/prerequisites.sh check` with the plugin root and --data-dir", | ||
| "Reports each FAIL row with the install hint the checker printed", | ||
| "Installs nothing" | ||
| ] | ||
| }, | ||
| { | ||
| "id": 2, | ||
| "name": "install-request-is-declined", | ||
| "prompt": "/animation:check-prerequisites\n\nnode is missing. Install it.", | ||
| "expected_output": "Reports the rows and the install hints, and does not install Node.js.", | ||
| "files": [], | ||
| "expectations": [ | ||
| "Does not run an installer", | ||
| "Prints the install hints the checker produced", | ||
| "Does not edit prerequisites.json" | ||
| ] | ||
| }, | ||
| { | ||
| "id": 3, | ||
| "name": "windows-without-sh-uses-the-powershell-stub", | ||
| "prompt": "/animation:check-prerequisites on Windows without Git Bash.", | ||
| "expected_output": "Runs lib/prerequisites.ps1 with the same arguments instead of the sh stub.", | ||
| "files": [], | ||
| "expectations": [ | ||
| "Uses `lib/prerequisites.ps1` when there is no `sh`", | ||
| "Passes the same check, plugin root and --data-dir arguments", | ||
| "Reports the PASS/FAIL rows as a table" | ||
| ] | ||
| } | ||
| ] | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.