fix(claude-lanes): drop the repo-wide code-review queue - #651
Conversation
The code-review callers carried a job-level concurrency group keyed on the repository with `queue: max`, so every pull request's review ran one at a time across the whole repository. On claude-code-plugins 47 reviews sat pending behind a single running one. Reviews now run in parallel. The workflow-level per-PR group still cancels superseded runs. A usage limit (429) already fails fast in the reusable workflow (continue-on-error, classified as rate-limit) and the lane is advisory, so contention for the shared seat costs a red advisory check, never a blocked merge. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LnQjBqtHLbX5UWPWggk7vg
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Claude finished @kyle-sexton's task in 39s —— View job Security review (
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5160624151
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…site No lane caller carries `concurrency.queue` now, so ci-runner's actionlint config no longer needs the `queue` ignore for the hosted review caller. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LnQjBqtHLbX5UWPWggk7vg
|
Claude finished @kyle-sexton's task in 31s —— View job Security review (
|
No related issue: consistency follow-up to #651 ## Summary Every synced code-review caller and this repository's own security-review caller skip draft pull requests. This repository's own code-review caller did not. ## Fix Add `if: github.event.pull_request.draft == false` to the `review` job in `.github/workflows/claude-review.yml`, with the same comment the components carry. ## Verification - `actionlint .github/workflows/claude-review.yml` passes. - With comments stripped, the caller now differs from `components/claude-lanes/claude-review.yml` only in the documented `runner` deviation. ## Related - #651 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01LnQjBqtHLbX5UWPWggk7vg Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: reviews on claude-code-plugins stalled behind a repo-wide queue (47 pending runs)
Summary
The code-review callers (
components/claude-lanes/claude-review.yml,components/claude-lanes-hosted/claude-review.yml, and this repo's own.github/workflows/claude-review.yml) had a job-level concurrency groupclaude-review-${{ github.repository }}withqueue: max. That runs every pull request's review one at a time across the whole repository. On claude-code-plugins, 47 reviews were pending behind one running review.Fix
cancel-in-progress: true) stays, so a newer push still supersedes an older review.distribution/README.md, which described the code-review queue.claude-lanes.test.shcontrol case that asserted synced lane callers need the actionlintqueuesuppression; no lane caller usesqueuenow. The suppression in.github/actionlint.yamlstays for other uses.A usage limit (429) already fails fast in the ci-workflows reusable (continue-on-error, classified
rate-limit), and the lane is advisory (github-iac ADR 0011), so parallel reviews contending for the seat produce a red advisory check, never a blocked merge. The security lane is unchanged: it never had a repo-wide queue.Verification
actionlint .github/workflows/claude-review.ymlpasses.claude-lanes.test.shcould not run cleanly in the local sandbox (56 failures on unmodified main, 55 with this change: the removed control assertion). CI is the check of record.Related
sync.ymlopens on push to main.🤖 Generated with Claude Code
https://claude.ai/code/session_01LnQjBqtHLbX5UWPWggk7vg