Skip to content

chore(changelogs): document broken Dojo bundle fix for 7 widgets#2338

Merged
r0b1n merged 1 commit into
mainfrom
fix/broken-bundle-changelogs
Jul 17, 2026
Merged

chore(changelogs): document broken Dojo bundle fix for 7 widgets#2338
r0b1n merged 1 commit into
mainfrom
fix/broken-bundle-changelogs

Conversation

@r0b1n

@r0b1n r0b1n commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Adds [Unreleased] changelog entry to 7 widgets whose released builds emitted broken JS bundles that failed to load in the Dojo client
  • Root cause: the dependency update in chore: pwt update #2252 caused Babel helpers to be emitted as dangling top-level functions instead of inside the AMD define([...]) wrapper; fixed in chore: bump babel targets to prevent inclusion of helpers #2291
  • Affected widgets: slider-web (3.0.3), range-slider-web (3.0.2), html-element-web (1.2.8 & 1.2.9), popup-menu-web (4.3.0), color-picker-web (2.1.7), document-viewer-web (1.2.1), signature-web (2.0.0)
  • data-widgets already has the fix captured in its 3.11.2 release changelog

Test plan

  • Verify [Unreleased] section is present and correct in all 7 widget CHANGELOGs
  • No version bumps — those happen at release time, one widget at a time

Adds [Unreleased] changelog entry to slider-web, range-slider-web,
html-element-web, popup-menu-web, color-picker-web, document-viewer-web,
and signature-web. Releases of these widgets built between the pwt update
(#2252) and the babel targets bump (#2291) emitted broken JS bundles that
failed to load in the Dojo client.
@github-actions

Copy link
Copy Markdown
Contributor

AI Code Review

✅ Approved — no issues found


What was reviewed

File Change
packages/pluggableWidgets/color-picker-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle
packages/pluggableWidgets/document-viewer-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle
packages/pluggableWidgets/html-element-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle
packages/pluggableWidgets/popup-menu-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle
packages/pluggableWidgets/range-slider-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle
packages/pluggableWidgets/signature-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle
packages/pluggableWidgets/slider-web/CHANGELOG.md Added [Unreleased] ### Fixed entry for broken Dojo bundle

Skipped (out of scope): dist/, pnpm-lock.yaml


Positives

  • All 7 entries correctly use the [Unreleased] section — no premature version bumps, consistent with the repo convention that version bumps happen in a dedicated release PR.
  • Entry wording is user-facing and behaviour-focused ("not loading in the Dojo client"), not an internal implementation detail — exactly what changelogs for users should contain per AGENTS.md.
  • Identical, consistent wording across all 7 widgets makes the batch change easy to verify at a glance.
  • PR title follows conventional commits format (chore(changelogs): …) and the body clearly documents root cause, fix PR reference, and affected versions — well-scoped and traceable.

@r0b1n
r0b1n merged commit 34eccd5 into main Jul 17, 2026
19 of 21 checks passed
@r0b1n
r0b1n deleted the fix/broken-bundle-changelogs branch July 17, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants