fix: write valid show-page parameter mappings#338
Open
hjotha wants to merge 1 commit intomendixlabs:mainfrom
Open
fix: write valid show-page parameter mappings#338hjotha wants to merge 1 commit intomendixlabs:mainfrom
hjotha wants to merge 1 commit intomendixlabs:mainfrom
Conversation
Symptom: executing described show-page actions with page parameter mappings could write an MPR that Studio Pro refused to load because the PageParameterMapping.Variable property was null. Root cause: the writer emitted nil for the Forms$PageParameterMapping Variable field and used the mapping count as the storage-list marker. Fix: emit the expected empty Forms$PageVariable object and use the standard Mendix storage-list marker for FormSettings parameter mappings. Tests: add a BSON-level ShowPageAction regression test that asserts the marker and non-null Forms$PageVariable payload, plus the existing show-page roundtrip tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forms$PageParameterMapping.Variableas a valid emptyForms$PageVariableobject instead ofnullFormSettings.ParameterMappingsrather than the mapping countWhy
Studio Pro rejects
PageParameterMapping.Variable = nullwhile loading a project.mxcli execcould succeed, but the resulting MPR was not openable when a show-page action contained page parameter mappings.Validation
make buildmake lint-gomake testCloses #295.
Related to #332.