Repository navigation
Improve slash-command menus and add local usage, copy, theme and exit commands - #83
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Stale web navigation history, hidden availability reasons in compact terminals, and untranslated new terminal labels remain unresolved.
3 open findings
What changed in this PR
This PR aligns terminal and web slash-command menus so blocked settings, confirmation, and Back and Cancel behavior are clearer.
Changes:
- Distinguishes unavailable settings from browse-only help and offers Refresh.
- Consolidates review and confirmation actions, tracks visited screens for Back, and updates selection styling.
- Updates browser and terminal tests, documentation, and embedded web assets.
| File | Description |
|---|---|
| web/tests/browser.spec.ts | Tests command availability, navigation, and confirmation. |
| web/src/SessionCommands.svelte | Updates the web command menu. |
| README.md | Documents the revised command flow. |
| internal/web/dist/index.html | Points to rebuilt web assets. |
| internal/web/dist/assets/index-l8TP2B-n.css | Removes the previous stylesheet. |
| internal/web/dist/assets/index-GcuOkuuL.css | Adds the rebuilt stylesheet. |
| internal/web/dist/assets/index-BHlnMEGS.js | Removes the previous script bundle. |
| internal/ui/monitor_suggestions.go | Changes suggestion selection styling. |
| internal/ui/monitor_suggestions_test.go | Checks the new styling. |
| internal/ui/monitor_commands.go | Updates terminal command navigation and actions. |
| internal/ui/monitor_commands_test.go | Tests terminal command behavior. |
| internal/codex/session_directory_unix.go | Marks blocked directory changes unavailable. |
| internal/codex/session_commands.go | Adds an availability reason to command choices. |
| internal/codex/session_commands_unix.go | Distinguishes blocked settings from help. |
| internal/codex/session_commands_unix_test.go | Tests blocked-setting availability. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
merefield
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slash-command menus labelled blocked settings as
// HELP, showed inconsistent confirmation hints, and inferred Back destinations from RPC paths. This makes availability, selection and navigation explicit in terminal and web menus, and adds local aliases for existing interface controls./fasthas no Back on its initial options screen. Rename/directory review preserves edited values. Cancel closes the menu, preserves the slash draft and restores composer focus when available. Every menu exit clears navigation history, so reopening a direct command cannot inherit an old Back destination./usageopens usage history;/copyreuses the session Copy action and its complete observed reply/activity payload;/themeselects and saves a terminal theme or focuses the existing browser theme selector;/exit//quitquit the terminal interface or leave browser session detail for Sessions.Local aliases work without the shared Codex daemon, including read-only browser full detail. Their scope is explained in the catalogue; exit leaves Codex sessions and the browser server running. Local aliases do not send app-server mutations, and their names are reserved against model-advertised speed aliases. Missing copy text produces feedback. README and the slash-command roadmap describe the completed local families.
Session-setting changes retain their existing idle requirement, revision checks and explicit confirmation.
Validation: 94 browser cases verified, including focused reruns after correcting readiness waits in the new navigation tests; Svelte/type/format checks and web build passed; Go race/coverage checks across all packages passed excluding exhaustive locale screenshots, including compact blocked-feedback tests, catalogue validation and localized command rendering in German, Japanese and Finnish; Go vet and Windows amd64 application/UI-test cross-builds passed. Updated embedded web assets are included.