feat(client): add the runner API and export the HTTP client as client/http by grubmeshi · Pull Request #33 · meshcloud/meshstack-cli

grubmeshi · 2026-10-13T13:30:16Z

🤖 Written by AI agent

building-block-runner moves all its runners into one Go binary (meshcloud/building-block-runner#86). It builds its meshStack client through pkg/auth.ResolveClient, as the Terraform provider does, and needs a client it can call from another module.

Reading order

Move. internal/http becomes client/http and internal/version becomes client/types/version, with only the imports rewritten.
client/http API. No exported name of client uses an internal/ type any more, and TestPublicApiNamesNoInternalType checks it. New client options: WithoutRedirects(), and WithRetry(policy), which picks per request which failures are retried. Without options, NewClient returns the shared client as before.
client.Runner. A runner claims a run, registers as a status source, reports status, and downloads or uploads the plan artifact, using the run token. ForRunUuid reports with the runner's own credentials. A run's implementation decodes into one typed variant by its type; the Terraform variant carries async. An INTEGER input keeps every digit as *big.Int. NewRunnerClient builds this API alone.
Comments that pointed into the old runner layout.

Changes for callers of `client`

WithHeader replaces WithAccept and WithHeaders, and WithBody takes the content type.
Send returns the raw response, and an Error names the method and URL.
The client.Authorization alias is gone; use http.Authorization.
ListOptions and Page move to client/types.

Merge order

Merge and release this first. #86 then pins the release in place of this branch's head.

Cross-repo PRs

feat!: run every building block runner type in one Go binary building-block-runner#86: every runner type in one Go binary, built on this PR
meshcloud/meshfed-release#11468: the deployments on the Go runner, and the Panel setup of runners of all types

🤖 Generated with Claude Code

meshcloud-gh-actions · 2026-10-13T13:41:09Z

Coverage of the acceptance run against the meshStack backend, on c85b993f740291325ffa98211bb268a0070d30b0.

Scope	Coverage
Unit tests	`77.6%`
Acceptance tests	`53.6%`
Combined	`80.0%`

Uncovered functions

client/api_key.go:55: meshApiKeyClient.Create 0.0%
client/api_key.go:59: meshApiKeyClient.Read 0.0%
client/api_key.go:63: meshApiKeyClient.Update 0.0%
client/api_key.go:71: meshApiKeyClient.Delete 0.0%
client/api_key_permissions.go:20: ApiKeyPermissions.AllCodes 0.0%
client/api_key_permissions.go:33: ApiKeyPermissions.WorkspaceCodes 0.0%
client/api_key_permissions.go:295: AllApiKeyPermissions 0.0%
client/api_key_permissions.go:299: WorkspacePermissionCodes 0.0%
client/building_block_definition.go:71: MeshBuildingBlockDefinitionApprovalPolicies.NothingRequiresApproval 0.0%
client/building_block_definition.go:82: DisabledSchedule 0.0%
client/building_block_definition.go:89: MeshBuildingBlockDefinitionSchedule.IsDisabled 0.0%
client/building_block_definition.go:93: MeshBuildingBlockDefinitionSpec.HasNeutralPolicies 0.0%
client/building_block_definition.go:97: MeshBuildingBlockDefinitionSpec.WithNeutralPolicies 0.0%
client/building_block_definition.go:166: meshBuildingBlockDefinitionClient.List 0.0%
client/building_block_definition.go:173: meshBuildingBlockDefinitionClient.Read 0.0%
client/building_block_definition.go:177: meshBuildingBlockDefinitionClient.Create 0.0%
client/building_block_definition.go:181: meshBuildingBlockDefinitionClient.Update 0.0%
client/building_block_definition.go:185: meshBuildingBlockDefinitionClient.Delete 0.0%
client/building_block_definition_version.go:100: MeshBuildingBlockType.TagInputTargets 0.0%
client/building_block_definition_version.go:245: meshBuildingBlockDefinitionVersionClient.Create 0.0%
client/building_block_definition_version.go:254: meshBuildingBlockDefinitionVersionClient.Update 0.0%
client/building_block_definition_version_implementation.go:80: MeshBuildingBlockDefinitionImplementation.InferType 0.0%
client/building_block_definition_version_implementation.go:94: MeshBuildingBlockDefinitionImplementation.MarshalJSON 0.0%
client/building_block_definition_version_implementation.go:107: *MeshBuildingBlockDefinitionImplementation.UnmarshalJSON 0.0%
client/building_block_runner.go:87: meshBuildingBlockRunnerClient.Create 0.0%
... and 136 more

covdata func names a method without its receiver, so an entry can belong to an implementation nothing selects rather than to a function the tests never reached. Open the file and line before reading one as a coverage gap.

… to client/types/version Another module may not import an internal package, so client.New, which takes an http.Client, could only be called from this module. A pure move with the imports rewritten. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…ptions client.New and RawClient.DoRequest are now callable from another module: no exported name of client uses an internal type, which TestPublicApiNamesNoInternalType keeps that way. So ListOptions and Page move to client/types, the client.Authorization alias goes, and the API docs download moves to internal/apidocs, its only caller. NewClient takes WithoutRedirects and WithRetry, whose RetryPolicy picks per request which of RetryOnBusy, RetryOnGatewayError and RetryOnBrokenConnection apply; without options it returns the shared client as before. WithHeader replaces WithAccept and WithHeaders, WithBody takes the content type, Send returns the raw response, and an Error names the method and URL. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

…rClient A building block runner claims runs, registers as a status source, reports status and moves the plan artifact through client.Runner, with the run token for every request about a run. ForRunUuid reports with the runner's own credentials, which outlive the run token. The implementation of a run is decoded into one typed variant by its type, the Terraform one with async. NewRunnerClient builds only this API, since client.New builds every meshObject client and logs a debug line for each. client/http gains what the runner needs: streaming a download, a request body read from a file and reopened on a retry, and PATCH. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

sonarqubecloud · 2026-10-29T14:19:53Z

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

grubmeshi force-pushed the feature/single-go-bin-runner branch from f7111e1 to 73db1b9 Compare October 13, 2026 13:52

grubmeshi changed the title ~~feat(client): publish the HTTP layer as client/http, with Basic auth~~ feat: basic auth credential and the runner API in client Oct 13, 2026

grubmeshi force-pushed the feature/single-go-bin-runner branch from 73db1b9 to ebf91ce Compare October 13, 2026 13:58

This was referenced Oct 13, 2026

feat!: run every building block runner type in one Go binary meshcloud/building-block-runner#86

Open

refactor: run the Go runners on the meshstack-cli client meshcloud/building-block-runner#87

Closed

grubmeshi force-pushed the feature/single-go-bin-runner branch 2 times, most recently from 9ab69a7 to 322b873 Compare October 15, 2026 19:18

grubmeshi mentioned this pull request Oct 22, 2026

bb-run-approve-abort: approve and abort building block runs #27

Merged

grubmeshi force-pushed the feature/single-go-bin-runner branch 10 times, most recently from 3a034bf to eb512e3 Compare October 23, 2026 11:53

grubmeshi mentioned this pull request Oct 23, 2026

docs: describe github_workflows.repository as the bare repository name meshcloud/terraform-provider-meshstack#354

Merged

grubmeshi changed the title ~~feat: basic auth credential and the runner API in client~~ feat: basic auth, client/http and the runner API in client Oct 23, 2026

grubmeshi force-pushed the feature/single-go-bin-runner branch 2 times, most recently from 5975d78 to 98854c7 Compare October 28, 2026 11:58

grubmeshi mentioned this pull request Oct 28, 2026

feat!: drop async from the Terraform implementation of a building block definition meshcloud/terraform-provider-meshstack#361

Closed

grubmeshi force-pushed the feature/single-go-bin-runner branch 3 times, most recently from abbd309 to e90226d Compare October 29, 2026 04:56

grubmeshi changed the title ~~feat: basic auth, client/http and the runner API in client~~ feat(client): add the runner API and export the HTTP client as client/http Oct 29, 2026

grubmeshi and others added 2 commits October 29, 2026 15:17

docs: point to the runner's tf executor in comments

c85b993

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

grubmeshi force-pushed the feature/single-go-bin-runner branch from e90226d to c85b993 Compare October 29, 2026 14:19

Navigation Menu

Repository navigation

feat(client): add the runner API and export the HTTP client as client/http - #33

feat(client): add the runner API and export the HTTP client as client/http#33
grubmeshi wants to merge 4 commits into
mainfrom
feature/single-go-bin-runner

grubmeshi commented Oct 13, 2026 •

edited

Loading

Uh oh!

meshcloud-gh-actions Bot commented Oct 13, 2026 •

edited

Loading

Uh oh!

sonarqubecloud Bot commented Oct 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

grubmeshi commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reading order

Changes for callers of client

Merge order

Cross-repo PRs

Uh oh!

meshcloud-gh-actions Bot commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud Bot commented Oct 29, 2026

Quality Gate passed

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

grubmeshi commented Oct 13, 2026 •

edited

Loading

Changes for callers of `client`

meshcloud-gh-actions Bot commented Oct 13, 2026 •

edited

Loading