Skip to content

bb-health-status: read healthStatus and action from the building block status - #55

Merged
grubmeshi merged 1 commit into
mainfrom
feature/bb-health-status
Oct 26, 2026
Merged

grubmeshi merged 1 commit into
mainfrom
feature/bb-health-status

Conversation

@grubmeshi

@grubmeshi grubmeshi commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

bb-health-status

meshStack reports status.healthStatus and status.action on meshBuildingBlock v2, and documents status.status as deprecated. This feature lets the Terraform provider expose both fields and a derived status.succeeded, deprecates status.status there, and moves the meshstack-hub checks to status.succeeded. The backend reports an aborted run, which includes a rejected approval, as the new action REVIEW_ABORTED_RUN, so succeeded also catches an abort.

This PR adds HealthStatus and Action to MeshBuildingBlockV2Status, with REVIEW_ABORTED_RUN in the action values. Both fields are served since meshStack 2026.34.0, below the client's floor.

Cross-repo PRs

🤖 Generated with Claude Code

@meshcloud-gh-actions

meshcloud-gh-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Coverage of the acceptance run against the meshStack backend, on 4f6255b5165a47f60d8daba6f64afee845248f9d.

Scope Coverage
Unit tests 78.2%
Acceptance tests 54.0%
Combined 80.3%
Uncovered functions
client/api_key.go:55: meshApiKeyClient.Create 0.0%
client/api_key.go:59: meshApiKeyClient.Read 0.0%
client/api_key.go:63: meshApiKeyClient.Update 0.0%
client/api_key.go:71: meshApiKeyClient.Delete 0.0%
client/api_key_permissions.go:20: ApiKeyPermissions.AllCodes 0.0%
client/api_key_permissions.go:33: ApiKeyPermissions.WorkspaceCodes 0.0%
client/api_key_permissions.go:295: AllApiKeyPermissions 0.0%
client/api_key_permissions.go:299: WorkspacePermissionCodes 0.0%
client/building_block_definition.go:71: MeshBuildingBlockDefinitionApprovalPolicies.NothingRequiresApproval 0.0%
client/building_block_definition.go:82: DisabledSchedule 0.0%
client/building_block_definition.go:89: MeshBuildingBlockDefinitionSchedule.IsDisabled 0.0%
client/building_block_definition.go:93: MeshBuildingBlockDefinitionSpec.HasNeutralPolicies 0.0%
client/building_block_definition.go:97: MeshBuildingBlockDefinitionSpec.WithNeutralPolicies 0.0%
client/building_block_definition.go:166: meshBuildingBlockDefinitionClient.List 0.0%
client/building_block_definition.go:173: meshBuildingBlockDefinitionClient.Read 0.0%
client/building_block_definition.go:177: meshBuildingBlockDefinitionClient.Create 0.0%
client/building_block_definition.go:181: meshBuildingBlockDefinitionClient.Update 0.0%
client/building_block_definition.go:185: meshBuildingBlockDefinitionClient.Delete 0.0%
client/building_block_definition_version.go:100: MeshBuildingBlockType.TagInputTargets 0.0%
client/building_block_definition_version.go:245: meshBuildingBlockDefinitionVersionClient.Create 0.0%
client/building_block_definition_version.go:254: meshBuildingBlockDefinitionVersionClient.Update 0.0%
client/building_block_definition_version_implementation.go:80: MeshBuildingBlockDefinitionImplementation.InferType 0.0%
client/building_block_definition_version_implementation.go:94: MeshBuildingBlockDefinitionImplementation.MarshalJSON 0.0%
client/building_block_definition_version_implementation.go:107: *MeshBuildingBlockDefinitionImplementation.UnmarshalJSON 0.0%
client/building_block_runner.go:87: meshBuildingBlockRunnerClient.Create 0.0%
... and 125 more

covdata func names a method without its receiver, so an entry can belong to an implementation nothing selects rather than to a function the tests never reached. Open the file and line before reading one as a coverage gap.

@grubmeshi
grubmeshi marked this pull request as ready for review October 26, 2026 09:38
@grubmeshi
grubmeshi requested a review from sttomm October 26, 2026 09:38
@grubmeshi
grubmeshi force-pushed the feature/bb-health-status branch 2 times, most recently from d2dbc70 to 847cfd4 Compare October 26, 2026 13:03
Comment thread client/building_block_v2.go
@grubmeshi
grubmeshi force-pushed the feature/bb-health-status branch from 847cfd4 to 2d308f5 Compare October 26, 2026 13:59
…atus

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@grubmeshi
grubmeshi force-pushed the feature/bb-health-status branch from 2d308f5 to 4f6255b Compare October 26, 2026 14:16
@sonarqubecloud

Copy link
Copy Markdown

@grubmeshi
grubmeshi merged commit 4f6255b into main Oct 26, 2026
13 checks passed
@grubmeshi
grubmeshi deleted the feature/bb-health-status branch October 26, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants