Repository navigation
chore: drop async from every Terraform implementation - #406
Merged
Merged
Conversation
Contributor
Scorecard Check
📊 meshstack-hub Module Scorecard
📋 Per-Module Category SummaryScore per category per building block.
Core Structure — some checks failingBasic module file structure and documentation — applies to 45 modules
Core Structure — Summary
Integration — some checks failingmeshstack_integration.tf conventions — applies to 44 modules
Integration — Summary
AWS Backplane — some checks failingAWS automation principal conventions (WIF or cross-account StackSet) — applies to 1 modules
AWS Backplane — Summary
Azure Backplane — some checks failingAzure UAMI-based automation principal conventions — applies to 9 modules
Azure Backplane — Summary
GCP Backplane — ✅ all passingGCP workload-identity-federation automation principal conventions — applies to 2 modules
GCP Backplane — Summary
STACKIT Backplane — some checks failingSTACKIT WIF-based automation principal conventions — applies to 9 modules
STACKIT Backplane — Summary
Testing — some checks failingEnd-to-end test coverage — applies to 45 modules
Testing — Summary
📈 Overall SummaryOverall Average Score: 94%Score Distribution
|
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
meshStack provider v0.27.0 deprecates status.status on meshstack_building_block and adds status.succeeded, status.health_status and status.action. Postconditions, e2e assertions and the scorecard check move to them, and every touched module requires the provider at >= 0.27.0. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
meshStack runs Terraform building blocks synchronously, and the meshstack provider removes the attribute. Omitting it works with every provider version, so no minimum version changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
grubmeshi
force-pushed
the
feature/terraform-drop-async
branch
from
October 28, 2026 13:27
d6a9cc6 to
eab6b81
Compare
grubmeshi
marked this pull request as ready for review
October 28, 2026 13:27
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Building block runner v2 always runs Terraform synchronously (meshcloud/building-block-runner#86, meshcloud/meshfed-release#11468), so the Terraform implementation has no use for
async. GitHub workflows and Azure DevOps pipelines keep their ownasync.This PR removes
async = falsefrom every Terraform implementation (29 modules, 2 reference architectures and the e2e ofstackit/service-account-federation). Theasyncof the GitHub and Azure DevOps implementations stays.The provider minimums stay as they are: a configuration without
asyncworks with every provider version, because older providers default it to false, and the next provider release (v0.27.0) no longer accepts it.Related: meshcloud/meshstack-cli#58, meshcloud/terraform-provider-meshstack#362
🤖 Generated with Claude Code